Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD: objects can override is_dict_like() #8613

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ADD: objects can override is_dict_like() #8613

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion xarray/core/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,14 @@ def remove_incompatible_items(

# It's probably OK to give this as a TypeGuard; though it's not perfectly robust.
def is_dict_like(value: Any) -> TypeGuard[Mapping]:
return hasattr(value, "keys") and hasattr(value, "__getitem__")
"""Return whether to treat value like it is a dictionary.
Usually, just tests whether value has 'keys' and '__getitem__' attributes.
However, if value._xarray_dict_like_ exists, return that instead.
"""
try:
return value._xarray_dict_like_
except AttributeError:
return hasattr(value, "keys") and hasattr(value, "__getitem__")


def is_full_slice(value: Any) -> bool:
Expand Down
Loading