-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support non-str Hashables in DataArray #8559
Conversation
I think I've said this before but eventually I would like to see us use property-based testing and test using a strategy that generates arbitrary strings / hashables. We could build off of #6903 and generalise the |
We could add them onto a canonical test object like #8533 (maybe there's a param for "object with lots of quirks"), and then if we can spread that object throughout the test suite, we get every method tested on the full range of quirks (I see @TomNicholas just replied with a suggestion to use hypothesis — agree — I think that would provide more depth (more quirks!), though less wide coverage, given we're unlikely to write every test using hypothesis) |
Should we explicitly disallow using |
whats-new.rst
Probably we should add a whole bunch of tests for this. For now only testing the constructor.