-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate the other CI to python 3.11 #8416
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Automation
Github bots, testing workflows, release automation
label
Nov 5, 2023
keewis
added
run-upstream
Run upstream CI
and removed
Automation
Github bots, testing workflows, release automation
labels
Nov 5, 2023
Sounds great on all counts! |
github-actions
bot
added
the
Automation
Github bots, testing workflows, release automation
label
Nov 16, 2023
Shall we merge? |
before merging we probably need to silence the |
dcherian
added a commit
to rabernat/xarray
that referenced
this pull request
Nov 29, 2023
* main: [skip-ci] dev whats-new (pydata#8467) 2023.11.0 Whats-new (pydata#8461) migrate the other CI to python 3.11 (pydata#8416) preserve vlen string dtypes, allow vlen string fill_values (pydata#7869) Pin mypy < 1.7 (pydata#8458) Fix typos found by codespell (pydata#8457) [skip-ci] Small updates to IO docs. (pydata#8452) Deprecate certain cftime frequency strings following pandas (pydata#8415) Added driver parameter for h5netcdf (pydata#8360) Raise exception in to_dataset if resulting variable is also the name of a coordinate (pydata#8433) Automatic region detection and transpose for `to_zarr()` (pydata#8434) remove `cdms2` (pydata#8441) Remove PseudoNetCDF (pydata#8446) Pin pint to >=0.22 (pydata#8445) Remove keep_attrs from resample signature (pydata#8444) Rename `to_array` to `to_dataarray` (pydata#8438) Add missing DataArray.dt.total_seconds() method (pydata#8435) Declare Dataset, DataArray, Variable, GroupBy unhashable (pydata#8392)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Automation
Github bots, testing workflows, release automation
plan to merge
Final call for comments
run-upstream
Run upstream CI
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(namely, additional CI and upstream-dev CI)
python=3.11
has been released more than a year ago andpython=3.12
is out as well, which means that it is a good idea to migrate sooner than later.Regarding
python=3.12
, usually it isnumba
that keeps us from testing on a newpython
version for some time, wherenumbagg
andsparse
are the only dependencies that would use it. Should we create a environment without those two dependencies and switch back to the normal one oncenumba
supports the new python version?We still have the special environment files for
python>=3.11
because the normal ones still includecdms2
. We deprecated that back in May – not sure which release that ended up in – but sincecdms2
will be abandoned end of this year, that's when we're free to drop support and merge both environments (though maybe we can justify dropping support earlier?)