Skip to content

Commit

Permalink
Use assert_duckarray_allclose instead of rounding the array (#9313)
Browse files Browse the repository at this point in the history
* Cleanup test_coding_times

* Update test_coding_times.py

* Update test_coding_times.py

* Update test_coding_times.py
  • Loading branch information
Illviljan authored Aug 6, 2024
1 parent c508cc6 commit e2981d3
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions xarray/tests/test_coding_times.py
Original file line number Diff line number Diff line change
Expand Up @@ -146,14 +146,14 @@ def test_cf_datetime(num_dates, units, calendar) -> None:
# https://github.com/Unidata/netcdf4-python/issues/355
assert (abs_diff <= np.timedelta64(1, "s")).all()
encoded1, _, _ = encode_cf_datetime(actual, units, calendar)
assert_array_equal(num_dates, np.around(encoded1, 1))
assert_duckarray_allclose(num_dates, encoded1)

if hasattr(num_dates, "ndim") and num_dates.ndim == 1 and "1000" not in units:
# verify that wrapping with a pandas.Index works
# note that it *does not* currently work to put
# non-datetime64 compatible dates into a pandas.Index
encoded2, _, _ = encode_cf_datetime(pd.Index(actual), units, calendar)
assert_array_equal(num_dates, np.around(encoded2, 1))
assert_duckarray_allclose(num_dates, encoded2)


@requires_cftime
Expand Down

0 comments on commit e2981d3

Please sign in to comment.