Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add magentic third-party integration docs page #584

Merged
merged 7 commits into from
Nov 26, 2024

Conversation

jackmpcollins
Copy link
Contributor

https://github.com/jackmpcollins/magentic supports logfire thanks to the logfire-api package. More details https://magentic.dev/logging-and-tracing/

This follows similar style to the existing third-party integrations docs pages. Original suggestion to add magentic to the docs: #121 (comment)

screenshot image

Copy link
Contributor

@hyperlint-ai hyperlint-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 files reviewed, 2 total issue(s) found.

The style guide flagged several spelling errors that seemed like false positives. We skipped posting inline suggestions for the following words:

  • Magentic

docs/integrations/third-party/magentic.md Outdated Show resolved Hide resolved
docs/integrations/third-party/magentic.md Outdated Show resolved Hide resolved
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (8785c6b) to head (8778438).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #584   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          133       133           
  Lines        10567     10567           
  Branches      1450      1450           
=========================================
  Hits         10567     10567           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@hyperlint-ai hyperlint-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The style guide flagged several spelling errors that seemed like false positives. We skipped posting inline suggestions for the following words:

  • Magentic

Copy link
Contributor

@hyperlint-ai hyperlint-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 files reviewed, 2 total issue(s) found.


Note: We resolved prior Hyperlint review comments because:

We noticed a change to the style guide files.

We do this to avoid keeping outdated or irrelevant comments around. We'll leave a new review with current comments below.

docs/integrations/third-party/magentic.md Show resolved Hide resolved
docs/integrations/third-party/magentic.md Show resolved Hide resolved
Copy link
Contributor

@hyperlint-ai hyperlint-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The style guide flagged several spelling errors that seemed like false positives. We skipped posting inline suggestions for the following words:

  • LLMs

@Kludex Kludex enabled auto-merge (squash) November 26, 2024 12:18
@Kludex Kludex merged commit b8e0bef into pydantic:main Nov 26, 2024
13 checks passed
@jackmpcollins jackmpcollins deleted the add-magentic-integration branch November 27, 2024 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants