Feature: added EFC ASN.1 modules #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These bundles include DSRC, EFC, CCC, LAC, AutonomousCharging and InfoExchange specs with dependencies, such as X509 and RFC5035. These specs were obtained from the standards.iso.org/iso/ website. The ISO 14906 DSRC ASN.1 specs sometimes use Windows code pages to encode characters in comments. I replaced them for their ASCII counterparts where I could to avoid issues.
Again, the ASN.1 specs were modified to only contain ASCII characters (even in comments).
CCC imports from DSRC specs, so they are added as dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! This is my first PR, I hope I followed the proper etiquette.
Changes
In the first 3 out of the 5 commits, I:
DSRC, EFC, CCC, LAC, AutonomousCharging, InfoExchange + dependencies (X509, RFC5035)
I then also did 2 other commits with some tests.
I added them to the test/ dir. Please tell me if this impacts the CI/CD pipeline. Should I have added my custom tests to res/ instead?
Description
For each of the 3 first commits, I:
python -m pycrate_asn1c.asnprocto recompile all the specs