Adding log_delivery parameter to CDN create_service #577
Conversation
vikomall
force-pushed
the
cdn_log_directory
branch
from
32b6c34 to
6027890
Compare
| @@ -57,14 +57,15 @@ def delete_assets(self, url=None, all=False): | |||
| class CloudCDNServiceManager(BaseManager): | |||
|
|
|||
| def create(self, name, flavor_id, domains, origins, | |||
| restrictions=None, caching=None): | |||
| restrictions=None, caching=None, log_delivery=None): | |||
There was a problem hiding this comment.
Since this has to be True/False, this should be log_delivery=False
There was a problem hiding this comment.
Thanks @briancurtin for reviewing. Currently allowed value is {"enabled": "true/false"}, but in future if it supports some other key/values in this dictionary, for example {"enabled": "true", "log_path": "cloud-files-container-path"}, then we have to revisit this change.
So I am thinking current change is OK. Let me know what you think!
There was a problem hiding this comment.
If that happened, we'd just add a log_path=None argument and construct the appropriate body to go along with it.
There was a problem hiding this comment.
If we keep the current implementation, we need not touch it again.
There was a problem hiding this comment.
If we keep the current implementation, we will forever offer a sub-par experience.
vikomall
force-pushed
the
cdn_log_directory
branch
from
6027890 to
4695ed5
Compare
|
@briancurtin updated patch as suggested. |
Adding log_delivery parameter to CDN create_service.
Issue #576