Feature/approved fedora rpm updates #434
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Full details can be found in the package review ticket here: https://bugzilla.redhat.com/show_bug.cgi?id=1123044
…uirements from django
This finalizes changes required to meet Fedora package requirements and tags the resulting RPM as 1.9.0-2, including a meaningful changelog entry. When merging this upstream please preserve the changelog.
…opment This represents the suggested RPM approach for post-release development. We increment the version but set the RPM release tag to "0" which activates generation of time and git-based RPM release strings. I am assuming a next version of 1.9.1 When 1.9.1 is ready for release, increment the RPM release string to "1" as part of the commit forming the official release. Then, as the first post-release commit, repeat the changes seen in this commit for 1.9.2 (or whatever the appropriate next version will be).
|
The package review bugzilla entry provides some details about the changes represented in this pull request: |
|
My apologies for the delay in getting back to you. Per our HACKING guidelines, would you be able to create this pull request against the working branch instead? |
|
There are a few things now out of date with this PR. A few things that I know are affecting this:
Additionally, there are a few things that would need to change before this would be accepted:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bundles the changes I needed to make to get pyrax approved as a Fedora package. Most are RPM specific changes. The code changes are:
Remove #! headers from scripts that are not meant to be executable - This is a check done by rpmlint. We must pass rpmlint testing as part of the package approval process.
Add the license for slugify() inline - This code is 3-clause BSD and originally came from django, by way of an Activestate recipe. Adding explicit attribution and a copy of the license removes any uncertainty about compliance, which is good (and a requirement for Fedora).
The final commit sets up the RPM scripts and version/release details for ongoing development and explains how to change the values in preparation for the next release.