Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add backward compatibility for createmeta_issuetypes & createmeta_fieldtypes #1838

Merged
merged 7 commits into from
Mar 25, 2024

Conversation

paminov
Copy link
Contributor

@paminov paminov commented Mar 15, 2024

pr #1784 replaced createmeta_issuetypes & createmeta_fieldtypes with project_issue_types & project_issue_fields. This will break applications that use the library and utilize the createmeta_* methods.

@adehad
Copy link
Contributor

adehad commented Mar 21, 2024

thanks for this, could you add a deprecation warning to the functions before calling the replacement method.

@paminov
Copy link
Contributor Author

paminov commented Mar 22, 2024

thanks for this, could you add a deprecation warning to the functions before calling the replacement method.
@adehad thanks for pointing this out. I've added deprecation warnings to the methods.

jira/client.py Outdated Show resolved Hide resolved
jira/client.py Outdated Show resolved Hide resolved
Copy link
Contributor

@adehad adehad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks again, just did a small fix for the linter and docs to be happiest
image

@adehad adehad merged commit 4960d8f into pycontribs:main Mar 25, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants