Added 'notify' argument to the comment update() method #1008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osherdp
approved these changes
Mar 17, 2021
looks like the maintainers want to have the ci system back up and running before agreeing to any new merges. if you want to contribute to get yr pr through have a look here => #896 |
studioj
requested changes
May 7, 2021
| @@ -608,14 +608,14 @@ def __init__(self, options, session, raw=None): | |||
| if raw: | |||
| self._parse_raw(raw) | |||
|
|
|||
| def update(self, fields=None, async_=None, jira=None, body="", visibility=None): | |||
| def update(self, fields=None, async_=None, jira=None, body="", visibility=None, notify=True): | |||
| """Update a comment""" | |||
There was a problem hiding this comment.
@ronniel1 , could you please also extend the documentation of this method to describe the parameters
studioj
requested changes
May 11, 2021
| @@ -99,7 +99,6 @@ commands = | |||
| [testenv:lint] | |||
| deps = pre-commit>=1.17.0 | |||
| commands= | |||
| bash -c "npm install && npm run spell" | |||
There was a problem hiding this comment.
please pull all changes from the master and drop this change
ssbarnea
requested changes
May 15, 2021
studioj
added
the
Status: Needs Rework
|
I'm taking this one up myself |
Merged
|
taking this up in #1387 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The underlying update() method used, already supports the 'notify' argument.
Added that argument to Comment's update() method and propagated it on to Resource's update() method