Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor pynodeairq code example #464

Open
wants to merge 2 commits into
base: publish
Choose a base branch
from
Open

refactor pynodeairq code example #464

wants to merge 2 commits into from

Conversation

axelfauvel
Copy link

No description provided.

@aws-amplify-eu-central-1
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-464.d1rmdw1xyxqk1e.amplifyapp.com

@CLAassistant
Copy link

CLAassistant commented Nov 19, 2021 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Axel FAUVEL seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

axelfauvel
axelfauvel commented Nov 19, 2021
View reviewed changes
content/tutorials/pynode/pynodeairq.md
return (name_text,gas_res_d)

def air_quality_score(hum, gas_res):
def score_air_quality(hum, gas_res):
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gas_res argument is not used in this function. If it is not needed to calculate air quality, it should be removed

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could try to use this: https://github.com/G6EJD/BME680-Example/blob/master/ESP32_bme680_CC_demo_02.ino

@aws-amplify-eu-central-1
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-464.d1rmdw1xyxqk1e.amplifyapp.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xykon Xykon Awaiting requested review from Xykon

@msariisik msariisik Awaiting requested review from msariisik

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@axelfauvel @CLAassistant