-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add interface to save and resume SSL sessions (PR390) #234
base: publish
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor adjustments for readability.
@@ -38,13 +38,31 @@ ss.connect(socket.getaddrinfo('cloud.blynk.cc', 8441)[0][-1]) | |||
|
|||
SSL sockets inherit all methods and from the standard sockets, see the `usocket` module. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1st: SSL sockets inherit all methods from the standard sockets, see the usocket
module.
@@ -38,13 +38,31 @@ ss.connect(socket.getaddrinfo('cloud.blynk.cc', 8441)[0][-1]) | |||
|
|||
SSL sockets inherit all methods and from the standard sockets, see the `usocket` module. | |||
|
|||
`saved_session` : Takes a saved session instance of `ssl.SSLSocket`, and retrieve an already established TLS connection. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2nd: : Takes a saved session instance of ssl.SSLSocket
, and retrieves an already established TLS connection.
@@ -38,13 +38,31 @@ ss.connect(socket.getaddrinfo('cloud.blynk.cc', 8441)[0][-1]) | |||
|
|||
SSL sockets inherit all methods and from the standard sockets, see the `usocket` module. | |||
|
|||
`saved_session` : Takes a saved session instance of `ssl.SSLSocket`, and retrieve an already established TLS connection. | |||
|
|||
`timeout` : specify a Timeout in Seconds for the SSL handshake operation between client and server, default is 10 seconds |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3rd: specifies a Timeout in Seconds for the SSL handshake operation between client and server. The default is 10 seconds.
`timeout` : specify a Timeout in Seconds for the SSL handshake operation between client and server, default is 10 seconds | ||
|
||
#### ssl.save\_session(ssl_sock) | ||
|
||
Takes an instance `ssl_sock` of `ssl.SSLSocket`, and returns an instance of `ssl.SSLSession`. Saved session can be resumed later, thereby reducing mobile data and time required. Example: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4th: Takes an instance ssl_sock
of ssl.SSLSocket
, and returns an instance of ssl.SSLSession
. A saved session can be resumed later, thereby reducing mobile data and time required.
@lilycey : let me not modify these things as this is just a synchronization commit between the documentation of the development release and stable release. These corrections should be made in both documentation. |
To be merged when the feature is released in a stable release.
Feature is released as development version: not released yet
Documentation PR of the development version: #226