set coordinates to real symbols #170
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e-moral-sanchez
changed the title
yguclu
reviewed
Oct 14, 2024
There was a problem hiding this comment.
@e-moral-sanchez I suggest you add some basic tests for the TerminalExpr function (which is constructor of the namesake class in module sympde.expr.evaluation), and mark those which fail with @pytest.mark.xfail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Coordinates are
Sympysymbols which should have the attributereal=Trueto avoid problems with code generation.-This change breaks the
TerminalExprfunction.Linked to issue #169