-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
De Rham sequences w/ knot multiplicity > 1 #339
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iplicity nodes, few fixes to make it work
… function is called
…s in the periodic case
…n of greville pts
campospinto
reviewed
Oct 12, 2023
campospinto
reviewed
Oct 12, 2023
campospinto
reviewed
Oct 12, 2023
…sydac into fix_multiplicity_DeRham
yguclu
requested changes
Oct 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! I have only minor comments
…sydac into fix_multiplicity_DeRham
yguclu
approved these changes
Oct 24, 2023
@campospinto Do you have any further comments or questions on this PR? |
yguclu
changed the title
Fix multiplicity de Rham
Create de Rham sequences with knot multiplicity > 1
Oct 24, 2023
yguclu
changed the title
Create de Rham sequences with knot multiplicity > 1
De Rham sequences w/ knot multiplicity > 1
Oct 24, 2023
Just one minor suggestion ! Otherwise it looks good, thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable the use of the de Rham sequence with arbitrary knots multiplicity. With this we mean that the interior knots (all knots in the periodic case) can have a constant multiplicity higher than 1.
List of modifications
Changes in
core/bsplines.py
andcore/bsplines_kernels.py
:make_knots
function to create an appropriate knot sequence in all cases. In the non periodic case the interior knots are repeatedmultiplicity
times and the boundary knotsp+1
times. In the periodic case, interior knots are repeatedmultiplicity
times and we addp+1
knots at each side by periodicity. In all cases the number of knots is(n_cells-1) * multiplicity + 2 * (p+1)
.collocation_matrix
andhistopolation_matrix
to take in account that now in the periodic case the number of basis function islen(knots) - 2 * (p+1) + multiplicity
.greville
function for the maximum multiplicity case to avoid having the discontinuity points of the spline.Changes in modules
psydac.feec.derivatives
andpsydac.feec.global_projectors
to take in account that the ghost regions have sizeshifts * pads
(previously waspads
)Changes in
psydac.fem.splines
: repercussion of the changes inpsydac.core.bsplines
, addingmultiplicity
as argument to several functions. Correct the computation of themultiplicity
from the knot sequence.Add tests in
feec/tests/test_differentiation_matrices.py
andfeec/tests/test_global_projectors.py
with higher multiplicity.Add test in
api/tests/tests_api_feec_1d.py, api/tests/tests_api_feec_2d.py, api/tests/tests_api_feec_3d.py
with higher multiplicity.