-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make PYBIND11_WARNING_POP actually pop clang diagnostics #5448
base: master
Are you sure you want to change the base?
Commits on Nov 27, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d84c495 - Browse repository at this point
Copy the full SHA d84c495View commit details
Commits on Nov 29, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d310959 - Browse repository at this point
Copy the full SHA d310959View commit details -
Revert "fix: ignore -Wgnu-zero-variadic-macro-arguments on clang"
This reverts commit d310959.
Configuration menu - View commit details
-
Copy full SHA for 1a04f75 - Browse repository at this point
Copy the full SHA 1a04f75View commit details -
C++20 modernization: Use
__VA_OPT__(, ) __VA_ARGS__
in `PYBIND11_DE……CLARE_HOLDER_TYPE()`
Configuration menu - View commit details
-
Copy full SHA for 98b035a - Browse repository at this point
Copy the full SHA 98b035aView commit details
Commits on Nov 30, 2024
-
Disable
__VA_OPT__(, ) __VA_ARGS__
usage for MSVC (it is unclear to…… rwgk why it does not work). This is the beginning of the error message: ``` D:\a\pybind11\pybind11\tests\test_smart_ptr.cpp(285,1): error C2143: syntax error: missing ')' before ',' [D:\a\pybind11\pybind11\build\tests\pybind11_tests.vcxproj] D:\a\pybind11\pybind11\tests\test_smart_ptr.cpp(285,1): error C2059: syntax error: ')' [D:\a\pybind11\pybind11\build\tests\pybind11_tests.vcxproj] ```
Configuration menu - View commit details
-
Copy full SHA for 5c5dc8b - Browse repository at this point
Copy the full SHA 5c5dc8bView commit details -
Add `PYBIND11_WARNING_DISABLE_CLANG("-Wgnu-zero-variadic-macro-argume…
…nts")` in test_smart_ptr.cpp This is the error message: ``` /__w/pybind11/pybind11/tests/test_smart_ptr.cpp:287:51: error: must specify at least one argument for '...' parameter of variadic macro [-Werror,-Wgnu-zero-variadic-macro-arguments] PYBIND11_DECLARE_HOLDER_TYPE(T, std::shared_ptr<T>) ^ /__w/pybind11/pybind11/include/pybind11/cast.h:885:13: note: macro 'PYBIND11_DECLARE_HOLDER_TYPE' defined here ^ ```
Configuration menu - View commit details
-
Copy full SHA for a575ad6 - Browse repository at this point
Copy the full SHA a575ad6View commit details -
Also add `PYBIND11_WARNING_DISABLE_CLANG("-Wgnu-zero-variadic-macro-a…
…rguments")` in test_virtual_functions.cpp
Configuration menu - View commit details
-
Copy full SHA for be2c4cd - Browse repository at this point
Copy the full SHA be2c4cdView commit details -
Also add `PYBIND11_WARNING_DISABLE_CLANG("-Wgnu-zero-variadic-macro-a…
…rguments")` in test_embed/test_interpreter.cpp
Configuration menu - View commit details
-
Copy full SHA for 07859ca - Browse repository at this point
Copy the full SHA 07859caView commit details -
Configuration menu - View commit details
-
Copy full SHA for d01e3ef - Browse repository at this point
Copy the full SHA d01e3efView commit details -
1. Add `PYBIND11_WARNING_DISABLE_CLANG("-Wgnu-zero-variadic-macro-arg…
…uments")` near the top of pybind11/pybind11.h; 2. Change `PYBIND11_DECLARE_HOLDER_TYPE` macro to side-step the only remaining clang warning-as-error (this is still needed even for clang 18). Alternatively the warning suppression could be moved into pybind11/cast.h, but this commit limits the warning suppression to smaller scope within include/pybind11.
Configuration menu - View commit details
-
Copy full SHA for c9ce487 - Browse repository at this point
Copy the full SHA c9ce487View commit details