Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[smart_holder] Backport non-functional test changes from PR #5231 #5258

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

rwgk
Copy link
Collaborator

@rwgk rwgk commented Jul 22, 2024

Description

Non-functional test changes in support of PR #5213:

  1. To avoid compiler warnings for unused code in the unnamed namespace.
  2. To avoid clang-format changes.

Suggested changelog entry:

…: 1. To avoid compiler warnings for unused code in the unnamed namespace. 2. To avoid clang-format changes.
@rwgk rwgk marked this pull request as ready for review July 22, 2024 08:56
@rwgk rwgk merged commit ec557ff into pybind:smart_holder Jul 22, 2024
156 checks passed
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Jul 22, 2024
@rwgk rwgk deleted the backport_bakein_test_changes_sh branch July 22, 2024 08:57
@rwgk rwgk removed the needs changelog Possibly needs a changelog entry label Jul 22, 2024
rwgk pushed a commit to rwgk/pybind11 that referenced this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant