Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[smart_holder] Remove type_caster ODR guard #5255

Merged
merged 1 commit into from
Jul 20, 2024

Conversation

rwgk
Copy link
Collaborator

@rwgk rwgk commented Jul 20, 2024

Description

Preparation for merging PR #5213 into the smart_holder branch.

This rolls back PR #4022 (including follow-on tweaks in other PRs).

The type_caster ODR guard will continue to live in the http://github.com/google/pybind11clif repo.

Suggested changelog entry:

…ive in the pybind11k repo.)

This rolls back pybind#4022 (including follow-on tweaks in other PRs).
@rwgk rwgk requested a review from henryiii as a code owner July 20, 2024 06:22
@rwgk rwgk merged commit 800e5e1 into pybind:smart_holder Jul 20, 2024
156 checks passed
@rwgk rwgk deleted the sh_remove_test_type_caster_odr_guard branch July 20, 2024 06:55
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Jul 20, 2024
@rwgk rwgk removed the needs changelog Possibly needs a changelog entry label Jul 20, 2024
rwgk pushed a commit to rwgk/pybind11clif that referenced this pull request Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant