-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DEV-master-smart_holder] Bake smart_holder functionality into class_
and type_caster_base
#5213
Commits on Jun 29, 2024
-
Bring in smart_holder_poc.h from smart_holder branch (baby step).
Ralf W. Grosse-Kunstleve committedJun 29, 2024 Configuration menu - View commit details
-
Copy full SHA for 8b0b377 - Browse repository at this point
Copy the full SHA 8b0b377View commit details -
Add tests/test_wip.cpp,py (empty)
Ralf W. Grosse-Kunstleve committedJun 29, 2024 Configuration menu - View commit details
-
Copy full SHA for ced85c9 - Browse repository at this point
Copy the full SHA ced85c9View commit details -
Add
py::class_<SomeType>
with default ctor.Ralf W. Grosse-Kunstleve committedJun 29, 2024 Configuration menu - View commit details
-
Copy full SHA for e590748 - Browse repository at this point
Copy the full SHA e590748View commit details -
make smart_holder the default holder (baby step; does not build)
Ralf W. Grosse-Kunstleve committedJun 29, 2024 Configuration menu - View commit details
-
Copy full SHA for 97a3a49 - Browse repository at this point
Copy the full SHA 97a3a49View commit details -
fix build failure by introducing init_instance() specialization for s…
…mart_holder (test fails)
Ralf W. Grosse-Kunstleve committedJun 29, 2024 Configuration menu - View commit details
-
Copy full SHA for 00a9157 - Browse repository at this point
Copy the full SHA 00a9157View commit details -
Bring smart_holder init_instance_for_type<> directly into the init_in…
…stance() specialization. Also bring in dynamic_raw_ptr_cast_if_possible.h. Does not build because try_initialization_using_shared_from_this() is still missing.
Ralf W. Grosse-Kunstleve committedJun 29, 2024 Configuration menu - View commit details
-
Copy full SHA for fbf88cb - Browse repository at this point
Copy the full SHA fbf88cbView commit details -
Also bring in try_initialization_using_shared_from_this() from smart_…
…holder_type_casters.h. With this test_wip builds and succeeds.
Ralf W. Grosse-Kunstleve committedJun 29, 2024 Configuration menu - View commit details
-
Copy full SHA for 144ae8b - Browse repository at this point
Copy the full SHA 144ae8bView commit details -
Comment out or skip: with this test_class passes.
Ralf W. Grosse-Kunstleve committedJun 29, 2024 Configuration menu - View commit details
-
Copy full SHA for 9a88c09 - Browse repository at this point
Copy the full SHA 9a88c09View commit details -
Comment out or skip: with this test_pickling passes.
Ralf W. Grosse-Kunstleve committedJun 29, 2024 Configuration menu - View commit details
-
Copy full SHA for a1e312e - Browse repository at this point
Copy the full SHA a1e312eView commit details -
Comment out or skip: with this test_factory_constructors passes.
skip-checks: true
Ralf W. Grosse-Kunstleve committedJun 29, 2024 Configuration menu - View commit details
-
Copy full SHA for bcc3b87 - Browse repository at this point
Copy the full SHA bcc3b87View commit details -
Minimal reproducer for one of the test_factory_constructors.cpp build…
… errors.
Ralf W. Grosse-Kunstleve committedJun 29, 2024 Configuration menu - View commit details
-
Copy full SHA for 33b0b38 - Browse repository at this point
Copy the full SHA 33b0b38View commit details
Commits on Jun 30, 2024
-
Bring in pybind11/detail/class.h, init.h as-is from smart_holder bran…
…ch (does not build).
Ralf W. Grosse-Kunstleve committedJun 30, 2024 Configuration menu - View commit details
-
Copy full SHA for dfaa49b - Browse repository at this point
Copy the full SHA dfaa49bView commit details -
Remove stray line (probably from an accident/oversight a long time ag…
…o; harmless).
Ralf W. Grosse-Kunstleve committedJun 30, 2024 Configuration menu - View commit details
-
Copy full SHA for 03e6a93 - Browse repository at this point
Copy the full SHA 03e6a93View commit details -
pybind11/detail/init.h: replace type_uses_smart_holder_type_caster<> …
…with is_same<Holder<Class>, smart_holder> (still does not build).
Ralf W. Grosse-Kunstleve committedJun 30, 2024 Configuration menu - View commit details
-
Copy full SHA for e8cd429 - Browse repository at this point
Copy the full SHA e8cd429View commit details -
Bring in smart_holder_from_unique_ptr(), smart_holder_from_shared_ptr…
…() from smart_holder_type_casters.h (with this test_wip builds and runs successfully).
Ralf W. Grosse-Kunstleve committedJun 30, 2024 Configuration menu - View commit details
-
Copy full SHA for 381fdc5 - Browse repository at this point
Copy the full SHA 381fdc5View commit details -
Remove all (3) BAKEIN_BREAK from test_factory_constructors.cpp and al…
…l (4) BAKEIN_BREAK from test_factory_constructors.py (test_factory_constructors builds and runs successfully).
Ralf W. Grosse-Kunstleve committedJun 30, 2024 Configuration menu - View commit details
-
Copy full SHA for 8fe75ff - Browse repository at this point
Copy the full SHA 8fe75ffView commit details -
Add make_some_type() to test_wip (reproduces Segmentation fault in te…
…st_class).
Ralf W. Grosse-Kunstleve committedJun 30, 2024 Configuration menu - View commit details
-
Copy full SHA for c6a917e - Browse repository at this point
Copy the full SHA c6a917eView commit details
Commits on Jul 1, 2024
-
Remove is_holder_type<unique_ptr>
Ralf W. Grosse-Kunstleve committedJul 1, 2024 Configuration menu - View commit details
-
Copy full SHA for e4d0a55 - Browse repository at this point
Copy the full SHA e4d0a55View commit details -
Copy-paste-and-specialize copyable_holder_caster<shared_ptr>, move_on…
…ly_holder_caster<unique_ptr>. No functional changes.
Ralf W. Grosse-Kunstleve committedJul 1, 2024 Configuration menu - View commit details
-
Copy full SHA for 5518e01 - Browse repository at this point
Copy the full SHA 5518e01View commit details -
Introduce type_caster_base<>::unique_ptr_to_python()
Ralf W. Grosse-Kunstleve committedJul 1, 2024 Configuration menu - View commit details
-
Copy full SHA for 6ff547e - Browse repository at this point
Copy the full SHA 6ff547eView commit details -
Start pybind11/detail/smart_holder_type_caster_support.h, move unique…
…_ptr_to_python() there, add smart_holder_from_unique_ptr()
Ralf W. Grosse-Kunstleve committedJul 1, 2024 Configuration menu - View commit details
-
Copy full SHA for ae08f51 - Browse repository at this point
Copy the full SHA ae08f51View commit details -
Add pytest.skip("BAKEIN_BREAK: ...") in test_smart_ptr.py (all non-sk…
…ipped tests pass locally with C++17).
Ralf W. Grosse-Kunstleve committedJul 1, 2024 Configuration menu - View commit details
-
Copy full SHA for 8254d77 - Browse repository at this point
Copy the full SHA 8254d77View commit details
Commits on Jul 2, 2024
-
Add new include files to CMakeLists.txt, tests/extra_python_package/t…
…est_files.py
Ralf W. Grosse-Kunstleve committedJul 2, 2024 Configuration menu - View commit details
-
Copy full SHA for 7de474f - Browse repository at this point
Copy the full SHA 7de474fView commit details -
Merge branch 'master' into bakein
Ralf W. Grosse-Kunstleve committedJul 2, 2024 Configuration menu - View commit details
-
Copy full SHA for b0cfeec - Browse repository at this point
Copy the full SHA b0cfeecView commit details -
Remove pytest.skip("BAKEIN_BREAK: ...") in test_class.py (not needed …
…anymore).
Ralf W. Grosse-Kunstleve committedJul 2, 2024 Configuration menu - View commit details
-
Copy full SHA for 6c227c7 - Browse repository at this point
Copy the full SHA 6c227c7View commit details -
test_class.cpp: transfer CHECK_SMART_HOLDER from smart_holder branch …
…(replaces BAKEIN_BREAK).
Ralf W. Grosse-Kunstleve committedJul 2, 2024 Configuration menu - View commit details
-
Copy full SHA for 6b89ca0 - Browse repository at this point
Copy the full SHA 6b89ca0View commit details -
Bring in tests/pure_cpp/smart_holder_poc_test.cpp from smart_holder b…
…ranch as-is.
Ralf W. Grosse-Kunstleve committedJul 2, 2024 Configuration menu - View commit details
-
Copy full SHA for 107bcf9 - Browse repository at this point
Copy the full SHA 107bcf9View commit details -
Update .codespell-ignore-lines for tests/pure_cpp/smart_holder_poc_te…
…st.cpp
Ralf W. Grosse-Kunstleve committedJul 2, 2024 Configuration menu - View commit details
-
Copy full SHA for 9e3cdf7 - Browse repository at this point
Copy the full SHA 9e3cdf7View commit details -
Insert PYBIND11_SMART_HOLDER_PADDING (with the idea to catch undefine…
…d behavior sooner rather than later).
Ralf W. Grosse-Kunstleve committedJul 2, 2024 Configuration menu - View commit details
-
Copy full SHA for c92b4d8 - Browse repository at this point
Copy the full SHA c92b4d8View commit details -
Remove all BAKEIN_BREAK in test_pickling.cpp,py (tests pass without a…
…ny production code changes).
Ralf W. Grosse-Kunstleve committedJul 2, 2024 Configuration menu - View commit details
-
Copy full SHA for f84be2e - Browse repository at this point
Copy the full SHA f84be2eView commit details -
Replace BAKEIN_BREAK with BAKEIN_EXPECTED in test_smart_ptr_from_defa…
…ult().
Ralf W. Grosse-Kunstleve committedJul 2, 2024 Configuration menu - View commit details
-
Copy full SHA for 66a775e - Browse repository at this point
Copy the full SHA 66a775eView commit details -
Bring in tests/test_class_sh_basic.cpp,py from smart_holder branch as…
…-is (does not build).
Ralf W. Grosse-Kunstleve committedJul 2, 2024 Configuration menu - View commit details
-
Copy full SHA for b6171bc - Browse repository at this point
Copy the full SHA b6171bcView commit details -
Add no-op pybind11/smart_holder.h, 21 BAKEIN_BREAK in test_class_sh_b…
…asic.cpp, 26 BAKEIN_BREAK in test_class_sh_basic.py ``` ========================================================= short test summary info ========================================================== SKIPPED [1] test_class_sh_basic.py:59: got empty parameter set ('pass_f', 'rtrn_f', 'expected'), function test_load_with_rtrn_f at /usr/local/google/home/rwgk/forked/pybind11/tests/test_class_sh_basic.py:58 SKIPPED [1] test_class_sh_basic.py:70: got empty parameter set ('pass_f', 'rtrn_f', 'regex_expected'), function test_deleter_roundtrip at /usr/local/google/home/rwgk/forked/pybind11/tests/test_class_sh_basic.py:69 SKIPPED [1] test_class_sh_basic.py:99: got empty parameter set ('pass_f', 'rtrn_f', 'expected'), function test_pass_unique_ptr_disowns at /usr/local/google/home/rwgk/forked/pybind11/tests/test_class_sh_basic.py:98 SKIPPED [1] test_class_sh_basic.py:120: got empty parameter set ('pass_f', 'rtrn_f'), function test_cannot_disown_use_count_ne_1 at /usr/local/google/home/rwgk/forked/pybind11/tests/test_class_sh_basic.py:119 SKIPPED [1] test_class_sh_basic.py:145: BAKEIN_BREAK: AttributeError unique_ptr_roundtrip SKIPPED [1] test_class_sh_basic.py:157: unconditional skip SKIPPED [1] test_class_sh_basic.py:169: got empty parameter set ('pass_f', 'rtrn_f', 'moved_out', 'moved_in'), function test_unique_ptr_consumer_roundtrip at /usr/local/google/home/rwgk/forked/pybind11/tests/test_class_sh_basic.py:168 SKIPPED [1] test_class_sh_basic.py:210: BAKEIN_BREAK: AttributeError args_unique_ptr ====================================================== 17 passed, 8 skipped in 0.04s =======================================================```
Ralf W. Grosse-Kunstleve committedJul 2, 2024 Configuration menu - View commit details
-
Copy full SHA for 12b0130 - Browse repository at this point
Copy the full SHA 12b0130View commit details -
Fix oversights: Add pybind11/smart_holder.h in CMakeLists.txt, tests/…
…extra_python_package/test_files.py
Ralf W. Grosse-Kunstleve committedJul 2, 2024 Configuration menu - View commit details
-
Copy full SHA for a332fe8 - Browse repository at this point
Copy the full SHA a332fe8View commit details
Commits on Jul 3, 2024
-
Fix
rtrn_shmp
,rtrn_shmp
by transferring `smart_holder_from_share……d_ptr()` functionality from smart_holder branch.
Ralf W. Grosse-Kunstleve committedJul 3, 2024 Configuration menu - View commit details
-
Copy full SHA for 7a6d30c - Browse repository at this point
Copy the full SHA 7a6d30cView commit details -
Add
smart_holder_from_unique_ptr()
specialization for `std::unique_……ptr<T const, D>` Enables removing: 4 BAKEIN_BREAK in test_class_sh_basic.cpp 2 BAKEIN_BREAK in test_class_sh_basic.py
Ralf W. Grosse-Kunstleve committedJul 3, 2024 Configuration menu - View commit details
-
Copy full SHA for 5957133 - Browse repository at this point
Copy the full SHA 5957133View commit details -
Add
smart_holder_from_shared_ptr()
specialization for `std::shared_……ptr<T const>` Resolves one `// BAKEIN_WIP: Better Const2Mutbl`.
Ralf W. Grosse-Kunstleve committedJul 3, 2024 Configuration menu - View commit details
-
Copy full SHA for 556f28a - Browse repository at this point
Copy the full SHA 556f28aView commit details -
copyable_holder_caster<type, std::shared_ptr<type>>
: split `load_va……lue_shared_ptr()`, `load_value_smart_holder()` (the latter just throws right now)
Ralf W. Grosse-Kunstleve committedJul 3, 2024 Configuration menu - View commit details
-
Copy full SHA for 17c0354 - Browse repository at this point
Copy the full SHA 17c0354View commit details -
Rename
holder
toshared_ptr_holder
to improve readability. No fun……ctional changes.
Ralf W. Grosse-Kunstleve committedJul 3, 2024 Configuration menu - View commit details
-
Copy full SHA for 2837df1 - Browse repository at this point
Copy the full SHA 2837df1View commit details -
Add
value_and_holder loaded_v_h;
member (set, but currently unused).Ralf W. Grosse-Kunstleve committedJul 3, 2024 Configuration menu - View commit details
-
Copy full SHA for fc5678b - Browse repository at this point
Copy the full SHA fc5678bView commit details -
``` /__w/pybind11/pybind11/include/pybind11/cast.h:918:44: error: std::move of the variable 'v_h' of the trivially-copyable type 'pybind11::detail::value_and_holder' has no effect [performance-move-const-arg,-warnings-as-errors] return load_value_smart_holder(std::move(v_h)); ^ /__w/pybind11/pybind11/include/pybind11/cast.h:911:53: note: consider changing the 1st parameter of 'load_value_smart_holder' from 'pybind11::detail::value_and_holder &&' to 'const pybind11::detail::value_and_holder &' bool load_value_smart_holder(value_and_holder &&v_h) { ^ /__w/pybind11/pybind11/include/pybind11/cast.h:920:38: error: std::move of the variable 'v_h' of the trivially-copyable type 'pybind11::detail::value_and_holder' has no effect [performance-move-const-arg,-warnings-as-errors] return load_value_shared_ptr(std::move(v_h)); ^ /__w/pybind11/pybind11/include/pybind11/cast.h:895:51: note: consider changing the 1st parameter of 'load_value_shared_ptr' from 'pybind11::detail::value_and_holder &&' to 'const pybind11::detail::value_and_holder &' bool load_value_shared_ptr(value_and_holder &&v_h) { ^ ```
Ralf W. Grosse-Kunstleve committedJul 3, 2024 Configuration menu - View commit details
-
Copy full SHA for af66246 - Browse repository at this point
Copy the full SHA af66246View commit details -
Implement
operator std::shared_ptr<type> &()
, remove 2 BAKEIN_BREAK……: pass_shmp, pass_shcp
Ralf W. Grosse-Kunstleve committedJul 3, 2024 Configuration menu - View commit details
-
Copy full SHA for 224e934 - Browse repository at this point
Copy the full SHA 224e934View commit details -
move_only_holder_caster<type, std::unique_ptr<T, D>>
: inherit from ……`type_caster_base<T>` CRUDE INTERMEDIATE STATE, just to see if this builds on all platforms.
Ralf W. Grosse-Kunstleve committedJul 3, 2024 Configuration menu - View commit details
-
Copy full SHA for d4fc392 - Browse repository at this point
Copy the full SHA d4fc392View commit details
Commits on Jul 4, 2024
-
Remove
operator type *() unique_ptr
, and&
(not sure how they wou……ld be useful).
Ralf W. Grosse-Kunstleve committedJul 4, 2024 Configuration menu - View commit details
-
Copy full SHA for 391d772 - Browse repository at this point
Copy the full SHA 391d772View commit details -
Remove all but 3 BAKEIN_BREAK in test_class_sh_basic.cpp
Ralf W. Grosse-Kunstleve committedJul 4, 2024 Configuration menu - View commit details
-
Copy full SHA for 0eb23f2 - Browse repository at this point
Copy the full SHA 0eb23f2View commit details -
Implement
operator std::unique_ptr<type, deleter>()
. Resolves all b……ut 1 block of 4 BAKEIN_BREAK in test_class_sh_basic.py
Ralf W. Grosse-Kunstleve committedJul 4, 2024 Configuration menu - View commit details
-
Copy full SHA for ebbe066 - Browse repository at this point
Copy the full SHA ebbe066View commit details -
Add
cast(const std::unique_ptr<type, deleter> &, ...)
. Remove the l……ast 3 remaining BAKEIN_BREAK in test_class_sh_basic.cpp
Ralf W. Grosse-Kunstleve committedJul 4, 2024 Configuration menu - View commit details
-
Copy full SHA for 874f69d - Browse repository at this point
Copy the full SHA 874f69dView commit details
Commits on Jul 5, 2024
-
Merge branch 'master' into bakein
Ralf W. Grosse-Kunstleve authoredJul 5, 2024 Configuration menu - View commit details
-
Copy full SHA for 66fb5c9 - Browse repository at this point
Copy the full SHA 66fb5c9View commit details -
move_only_holder_caster<...unique_ptr...>::load_value()
:throw
in……stead of `return false` (i.e. prefer noisy failure over potentially silent failure).
Ralf W. Grosse-Kunstleve committedJul 5, 2024 Configuration menu - View commit details
-
Copy full SHA for fd1afdb - Browse repository at this point
Copy the full SHA fd1afdbView commit details -
Check for Python instance is uninitialized/disowned in type_caster_ba…
…se.h. CRUDE intermediate state, needs refactoring. All 4 remaining BAKEIN_BREAK removed from test_class_sh_basic.py. With that both test_class_sh_basic.cpp and test_class_sh_basic.py are identical to the smart_holder branch. All unit tests pass ASAN and MSAN testing with the Google-internal toolchain.
Ralf W. Grosse-Kunstleve committedJul 5, 2024 Configuration menu - View commit details
-
Copy full SHA for 0b7a628 - Browse repository at this point
Copy the full SHA 0b7a628View commit details -
inline shared_ptr_to_python() in cast.h
Ralf W. Grosse-Kunstleve committedJul 5, 2024 Configuration menu - View commit details
-
Copy full SHA for 12c0eb3 - Browse repository at this point
Copy the full SHA 12c0eb3View commit details -
inline unique_ptr_to_python() in cast.h
Ralf W. Grosse-Kunstleve committedJul 5, 2024 Configuration menu - View commit details
-
Copy full SHA for e593589 - Browse repository at this point
Copy the full SHA e593589View commit details -
Factor out smart_holder_value_and_holder_support.h to avoid code dupl…
…ication. All unit tests pass ASAN and MSAN testing with the Google-internal toolchain.
Ralf W. Grosse-Kunstleve committedJul 5, 2024 Configuration menu - View commit details
-
Copy full SHA for c84dacc - Browse repository at this point
Copy the full SHA c84daccView commit details -
Add missing
explicit
to resolve clang-tidy error.Ralf W. Grosse-Kunstleve committedJul 5, 2024 Configuration menu - View commit details
-
Copy full SHA for 46ab14e - Browse repository at this point
Copy the full SHA 46ab14eView commit details -
Bring in tests/test_class_sh_factory_constructors.cpp,py from smart_h…
…older branch as-is (tests pass without any further changes). All unit tests pass ASAN and MSAN testing with the Google-internal toolchain.
Ralf W. Grosse-Kunstleve committedJul 5, 2024 Configuration menu - View commit details
-
Copy full SHA for 470a765 - Browse repository at this point
Copy the full SHA 470a765View commit details -
Bring in all tests/test_class_*.cpp,py from smart_holder branch as-is…
… that pass without any further changes. All unit tests pass ASAN and MSAN testing with the Google-internal toolchain.
Ralf W. Grosse-Kunstleve committedJul 5, 2024 Configuration menu - View commit details
-
Copy full SHA for d9d9611 - Browse repository at this point
Copy the full SHA d9d9611View commit details -
Bring in tests/test_class_sh_shared_ptr_copy_move.cpp,py from smart_h…
…older branch as-is (does not build).
Ralf W. Grosse-Kunstleve committedJul 5, 2024 Configuration menu - View commit details
-
Copy full SHA for 4ce1524 - Browse repository at this point
Copy the full SHA 4ce1524View commit details -
Add
PYBIND11_TYPE_CASTER_BASE_HOLDER(...) (no-op)
Ralf W. Grosse-Kunstleve committedJul 5, 2024 Configuration menu - View commit details
-
Copy full SHA for fcc868d - Browse repository at this point
Copy the full SHA fcc868dView commit details -
Add more test_class_sh_* in tests/CMakeLists.txt
All unit tests pass ASAN and MSAN testing with the Google-internal toolchain.
Ralf W. Grosse-Kunstleve committedJul 5, 2024 Configuration menu - View commit details
-
Copy full SHA for 288442c - Browse repository at this point
Copy the full SHA 288442cView commit details -
Bring in tests/test_class_sh_mi_thunks.cpp,py from smart_holder branc…
…h as-is (Segmentation fault).
Ralf W. Grosse-Kunstleve committedJul 5, 2024 Configuration menu - View commit details
-
Copy full SHA for 25c8edf - Browse repository at this point
Copy the full SHA 25c8edfView commit details -
Add pytest.skip("BAKEIN_BREAK: ...") in test_class_sh_mi_thunks.py
Ralf W. Grosse-Kunstleve committedJul 5, 2024 Configuration menu - View commit details
-
Copy full SHA for 3466ce5 - Browse repository at this point
Copy the full SHA 3466ce5View commit details -
Bring in tests/test_class_sh_disowning_mi.cpp,py from smart_holder br…
…anch as-is (AssertionError).
Ralf W. Grosse-Kunstleve committedJul 5, 2024 Configuration menu - View commit details
-
Copy full SHA for 7173a3a - Browse repository at this point
Copy the full SHA 7173a3aView commit details -
Add pytest.skip("BAKEIN_BREAK: ...") in test_class_sh_disowning_mi.py
Ralf W. Grosse-Kunstleve committedJul 5, 2024 Configuration menu - View commit details
-
Copy full SHA for 34b8d36 - Browse repository at this point
Copy the full SHA 34b8d36View commit details -
Add test_class_sh_disowning_mi, test_class_sh_mi_thunks in CMakeLists…
….txt
Ralf W. Grosse-Kunstleve committedJul 5, 2024 Configuration menu - View commit details
-
Copy full SHA for 2180dd4 - Browse repository at this point
Copy the full SHA 2180dd4View commit details
Commits on Jul 6, 2024
-
Inline smart_holder_type_caster_support, trampoline_self_life_support…
… in type_caster_base.h: the organization of the existing code makes it very difficult to factor the added code properly.
Ralf W. Grosse-Kunstleve committedJul 6, 2024 Configuration menu - View commit details
-
Copy full SHA for 70ba91f - Browse repository at this point
Copy the full SHA 70ba91fView commit details -
Ralf W. Grosse-Kunstleve committed
Jul 6, 2024 Configuration menu - View commit details
-
Copy full SHA for af467ea - Browse repository at this point
Copy the full SHA af467eaView commit details -
throw from
convert_type()
to expose bug.``` ========================================================= short test summary info ========================================================== SKIPPED [4] test_class_sh_disowning_mi.py:67: BAKEIN_BREAK: AssertionError SKIPPED [2] test_class_sh_disowning_mi.py:43: BAKEIN_BREAK: AssertionError SKIPPED [2] test_class_sh_disowning_mi.py:54: BAKEIN_BREAK: AssertionError SKIPPED [1] test_class_sh_basic.py:156: unconditional skip SKIPPED [6] test_class_sh_mi_thunks.py:34: BAKEIN_BREAK: Segmentation fault SKIPPED [2] test_class_sh_mi_thunks.py:43: BAKEIN_BREAK: AssertionError SKIPPED [1] test_class_sh_mi_thunks.py:51: BAKEIN_BREAK: Failed: DID NOT RAISE <class 'ValueError'> SKIPPED [1] test_stl.py:149: no <experimental/optional> SKIPPED [1] test_smart_ptr.py:301: BAKEIN_EXPECTED: Failed: DID NOT RAISE <class 'RuntimeError'> FAILED test_class_sh_basic.py::test_load_with_mtxt[pass_shmp-Shmp-pass_shmp:Shmp(_MvCtor)*_MvCtor] - RuntimeError: BEAKIN_WIP: convert_type() called. FAILED test_class_sh_disowning_mi.py::test_disown_b - RuntimeError: BEAKIN_WIP: convert_type() called. FAILED test_class_sh_basic.py::test_unique_ptr_consumer_roundtrip[pass_valu-rtrn_lref-True-False] - RuntimeError: BEAKIN_WIP: convert_type() called. FAILED test_class_sh_basic.py::test_cannot_disown_use_count_ne_1[pass_udcp-rtrn_udcp] - RuntimeError: BEAKIN_WIP: convert_type() called. FAILED test_class_sh_basic.py::test_unique_ptr_roundtrip - RuntimeError: BEAKIN_WIP: convert_type() called. FAILED test_class_sh_basic.py::test_unique_ptr_consumer_roundtrip[pass_valu-rtrn_cref-True-False] - RuntimeError: BEAKIN_WIP: convert_type() called. FAILED test_class_sh_basic.py::test_load_with_mtxt[pass_uqmp-Uqmp-pass_uqmp:Uqmp(_MvCtor)*_MvCtor] - RuntimeError: BEAKIN_WIP: convert_type() called. FAILED test_class_sh_basic.py::test_load_with_mtxt[pass_uqcp-Uqcp-pass_uqcp:Uqcp(_MvCtor)*_MvCtor] - RuntimeError: BEAKIN_WIP: convert_type() called. FAILED test_class_sh_basic.py::test_load_with_rtrn_f[pass_udmp-rtrn_udmp-pass_udmp:rtrn_udmp] - RuntimeError: BEAKIN_WIP: convert_type() called. FAILED test_class_sh_basic.py::test_load_with_rtrn_f[pass_udcp-rtrn_udcp-pass_udcp:rtrn_udcp] - RuntimeError: BEAKIN_WIP: convert_type() called. FAILED test_class_sh_basic.py::test_deleter_roundtrip[pass_udcp_del-rtrn_udcp_del-pass_udcp_del:rtrn_udcp_del,udcp_deleter(_MvCtorTo)*_MvCtorTo] - RuntimeError: BEAKIN_WIP: convert_type() called. FAILED test_class_sh_basic.py::test_deleter_roundtrip[pass_udmp_del_nd-rtrn_udmp_del_nd-pass_udmp_del_nd:rtrn_udmp_del_nd,udmp_deleter_nd(_MvCtorTo)*_MvCtorTo] - RuntimeError: BEAKIN_WIP: convert_type() called. FAILED test_class_sh_basic.py::test_deleter_roundtrip[pass_udcp_del_nd-rtrn_udcp_del_nd-pass_udcp_del_nd:rtrn_udcp_del_nd,udcp_deleter_nd(_MvCtorTo)*_MvCtorTo] - RuntimeError: BEAKIN_WIP: convert_type() called. FAILED test_class_sh_disowning.py::test_same_twice - RuntimeError: BEAKIN_WIP: convert_type() called. FAILED test_class_sh_disowning.py::test_mixed - RuntimeError: BEAKIN_WIP: convert_type() called. FAILED test_class_sh_disowning.py::test_overloaded - RuntimeError: BEAKIN_WIP: convert_type() called. FAILED test_class_sh_basic.py::test_pass_unique_ptr_disowns[pass_udmp-rtrn_udmp-pass_udmp:rtrn_udmp] - RuntimeError: BEAKIN_WIP: convert_type() called. FAILED test_class_sh_basic.py::test_pass_unique_ptr_disowns[pass_udcp-rtrn_udcp-pass_udcp:rtrn_udcp] - RuntimeError: BEAKIN_WIP: convert_type() called. FAILED test_class_sh_basic.py::test_cannot_disown_use_count_ne_1[pass_uqmp-rtrn_uqmp] - RuntimeError: BEAKIN_WIP: convert_type() called. FAILED test_class_sh_basic.py::test_cannot_disown_use_count_ne_1[pass_uqcp-rtrn_uqcp] - RuntimeError: BEAKIN_WIP: convert_type() called. FAILED test_class_sh_basic.py::test_unique_ptr_consumer_roundtrip[pass_valu-rtrn_valu-True-True] - RuntimeError: BEAKIN_WIP: convert_type() called. FAILED test_class_sh_basic.py::test_pass_unique_ptr_disowns[pass_uqmp-rtrn_uqmp-pass_uqmp:rtrn_uqmp] - RuntimeError: BEAKIN_WIP: convert_type() called. FAILED test_class_sh_disowning_mi.py::test_disown_base1_first[MI1-1-2-None] - RuntimeError: BEAKIN_WIP: convert_type() called. FAILED test_class_sh_trampoline_shared_from_this.py::test_pure_cpp_sft_raw_ptr[make_pure_cpp_sft_unq_ptr] - RuntimeError: BEAKIN_WIP: convert_type() called. FAILED test_class_sh_trampoline_shared_from_this.py::test_pure_cpp_sft_raw_ptr[make_pure_cpp_sft_shd_ptr] - RuntimeError: BEAKIN_WIP: convert_type() called. FAILED test_class_sh_trampoline_basic.py::test_drvd0_add_in_cpp_unique_ptr - RuntimeError: BEAKIN_WIP: convert_type() called. FAILED test_class_sh_trampoline_basic.py::test_drvd1_add_in_cpp_unique_ptr - RuntimeError: BEAKIN_WIP: convert_type() called. FAILED test_class_sh_trampoline_self_life_support.py::test_m_big5 - RuntimeError: BEAKIN_WIP: convert_type() called. FAILED test_class_sh_trampoline_self_life_support.py::test_py_big5[0-Seed_CpCtor] - RuntimeError: BEAKIN_WIP: convert_type() called. FAILED test_class_sh_virtual_py_cpp_mix.py::test_get_from_cpp_unique_ptr[Base-5101] - RuntimeError: BEAKIN_WIP: convert_type() called. FAILED test_class_sh_virtual_py_cpp_mix.py::test_get_from_cpp_unique_ptr[PyBase-5323] - RuntimeError: BEAKIN_WIP: convert_type() called. FAILED test_class_sh_disowning_mi.py::test_disown_base2_first[MI1-1-2-None] - RuntimeError: BEAKIN_WIP: convert_type() called. FAILED test_class_sh_disowning_mi.py::test_disown_base2_first[MI2-3-4-1] - RuntimeError: BEAKIN_WIP: convert_type() called. FAILED test_class_sh_disowning_mi.py::test_disown_base2_first[MI3-5-6-1] - RuntimeError: BEAKIN_WIP: convert_type() called. FAILED test_class_sh_disowning_mi.py::test_disown_base2_first[MI4-7-8-1] - RuntimeError: BEAKIN_WIP: convert_type() called. FAILED test_class_sh_inheritance.py::test_rtrn_shmp_drvd_pass_shcp_base - RuntimeError: BEAKIN_WIP: convert_type() called. FAILED test_class_sh_inheritance.py::test_rtrn_shmp_drvd_up_cast_pass_shcp_drvd - RuntimeError: BEAKIN_WIP: convert_type() called. FAILED test_class_sh_trampoline_shared_from_this.py::test_std_make_shared_factory - AssertionError: assert 'BEAKIN_WIP: ...ype() called.' == 'smart_holder...ed_from_this.' FAILED test_class_sh_trampoline_shared_ptr_cpp_arg.py::test_shared_ptr_cpp_arg - RuntimeError: BEAKIN_WIP: convert_type() called. FAILED test_class_sh_trampoline_shared_ptr_cpp_arg.py::test_shared_ptr_cpp_prop - RuntimeError: BEAKIN_WIP: convert_type() called. FAILED test_class_sh_trampoline_shared_ptr_cpp_arg.py::test_shared_ptr_arg_identity - RuntimeError: BEAKIN_WIP: convert_type() called. FAILED test_class_sh_disowning_mi.py::test_disown_base2[MI6-12-1] - RuntimeError: BEAKIN_WIP: convert_type() called. FAILED test_class_sh_disowning_mi.py::test_disown_base2[MI7-13-4] - RuntimeError: BEAKIN_WIP: convert_type() called. FAILED test_class_sh_disowning_mi.py::test_disown_base2[MI8-14-1] - RuntimeError: BEAKIN_WIP: convert_type() called. FAILED test_class_sh_disowning_mi.py::test_disown_base2[MI8b-15-3] - RuntimeError: BEAKIN_WIP: convert_type() called. FAILED test_class_sh_trampoline_shared_from_this.py::test_multiple_registered_instances_for_same_pointee - RuntimeError: BEAKIN_WIP: convert_type() called. FAILED test_class_sh_trampoline_shared_from_this.py::test_multiple_registered_instances_for_same_pointee_leak - RuntimeError: BEAKIN_WIP: convert_type() called. FAILED test_class_sh_virtual_py_cpp_mix.py::test_get_from_cpp_unique_ptr[CppDerivedPlain-5202] - RuntimeError: BEAKIN_WIP: convert_type() called. FAILED test_class_sh_virtual_py_cpp_mix.py::test_get_from_cpp_unique_ptr[CppDerived-5212] - RuntimeError: BEAKIN_WIP: convert_type() called. FAILED test_class_sh_trampoline_shared_from_this.py::test_release_and_stash_leak - RuntimeError: BEAKIN_WIP: convert_type() called. FAILED test_class_sh_trampoline_shared_from_this.py::test_release_and_stash_via_shared_from_this - RuntimeError: BEAKIN_WIP: convert_type() called. FAILED test_class_sh_trampoline_shared_from_this.py::test_release_and_stash_via_shared_from_this_leak - RuntimeError: BEAKIN_WIP: convert_type() called. FAILED test_class_sh_trampoline_shared_from_this.py::test_pass_released_shared_ptr_as_unique_ptr - RuntimeError: BEAKIN_WIP: convert_type() called. FAILED test_class_sh_trampoline_shared_ptr_cpp_arg.py::test_shared_ptr_goaway - RuntimeError: BEAKIN_WIP: convert_type() called. FAILED test_class_sh_trampoline_shared_ptr_cpp_arg.py::test_infinite - RuntimeError: BEAKIN_WIP: convert_type() called. FAILED test_class_sh_trampoline_shared_ptr_cpp_arg.py::test_std_make_shared_factory[pass_through_shd_ptr] - RuntimeError: BEAKIN_WIP: convert_type() called. FAILED test_class_sh_trampoline_shared_ptr_cpp_arg.py::test_std_make_shared_factory[pass_through_shd_ptr_release_gil] - RuntimeError: BEAKIN_WIP: convert_type() called. FAILED test_class_sh_trampoline_unique_ptr.py::test_m_clone_and_foo - RuntimeError: BEAKIN_WIP: convert_type() called. FAILED test_class_sh_unique_ptr_member.py::test_pointee_and_ptr_owner[give_up_ownership_via_unique_ptr] - RuntimeError: BEAKIN_WIP: convert_type() called. FAILED test_class_sh_trampoline_self_life_support.py::test_py_big5[2-Seed_OpEqLv] - RuntimeError: BEAKIN_WIP: convert_type() called. FAILED test_class_sh_trampoline_self_life_support.py::test_py_big5[3-Seed_OpEqRv] - RuntimeError: BEAKIN_WIP: convert_type() called. FAILED test_class_sh_trampoline_shared_from_this.py::test_release_and_shared_from_this - RuntimeError: BEAKIN_WIP: convert_type() called. FAILED test_class_sh_trampoline_shared_from_this.py::test_release_and_shared_from_this_leak - RuntimeError: BEAKIN_WIP: convert_type() called. FAILED test_class_sh_basic.py::test_load_with_mtxt[pass_shcp-Shcp-pass_shcp:Shcp(_MvCtor)*_MvCtor] - RuntimeError: BEAKIN_WIP: convert_type() called. FAILED test_class_sh_disowning_mi.py::test_disown_base1_first[MI2-3-4-1] - RuntimeError: BEAKIN_WIP: convert_type() called. FAILED test_class_sh_basic.py::test_unique_ptr_consumer_roundtrip[pass_rref-rtrn_valu-True-True] - RuntimeError: BEAKIN_WIP: convert_type() called. FAILED test_class_sh_disowning_mi.py::test_disown_base1_first[MI3-5-6-1] - RuntimeError: BEAKIN_WIP: convert_type() called. FAILED test_class_sh_disowning_mi.py::test_disown_base1_first[MI4-7-8-1] - RuntimeError: BEAKIN_WIP: convert_type() called. FAILED test_class_sh_basic.py::test_pass_unique_ptr_disowns[pass_uqcp-rtrn_uqcp-pass_uqcp:rtrn_uqcp] - RuntimeError: BEAKIN_WIP: convert_type() called. FAILED test_class_sh_basic.py::test_cannot_disown_use_count_ne_1[pass_udmp-rtrn_udmp] - RuntimeError: BEAKIN_WIP: convert_type() called. FAILED test_class_sh_trampoline_unique_ptr.py::test_m_clone - RuntimeError: BEAKIN_WIP: convert_type() called. FAILED test_class_sh_disowning_mi.py::test_disown_base2_first[MI5-10-11-1] - RuntimeError: BEAKIN_WIP: convert_type() called. FAILED test_class_sh_trampoline_self_life_support.py::test_py_big5[1-Seed_MvCtor] - RuntimeError: BEAKIN_WIP: convert_type() called. FAILED test_class_sh_trampoline_shared_from_this.py::test_multiple_registered_instances_for_same_pointee_recursive - RuntimeError: BEAKIN_WIP: convert_type() called. FAILED test_class_sh_virtual_py_cpp_mix.py::test_get_from_cpp_unique_ptr[PyCppDerived-5434] - RuntimeError: BEAKIN_WIP: convert_type() called. FAILED test_class_sh_trampoline_basic.py::test_drvd0_add_in_cpp_shared_ptr - RuntimeError: BEAKIN_WIP: convert_type() called. FAILED test_class_sh_trampoline_shared_from_this.py::test_release_and_stash - RuntimeError: BEAKIN_WIP: convert_type() called. FAILED test_class_sh_basic.py::test_deleter_roundtrip[pass_udmp_del-rtrn_udmp_del-pass_udmp_del:rtrn_udmp_del,udmp_deleter(_MvCtorTo)*_MvCtorTo] - RuntimeError: BEAKIN_WIP: convert_type() called. FAILED test_class_sh_unique_ptr_member.py::test_pointee_and_ptr_owner[give_up_ownership_via_shared_ptr] - RuntimeError: BEAKIN_WIP: convert_type() called. FAILED test_class_sh_trampoline_shared_from_this.py::test_pure_cpp_sft_raw_ptr[make_pure_cpp_sft_raw_ptr] - RuntimeError: BEAKIN_WIP: convert_type() called. FAILED test_class_sh_trampoline_shared_ptr_cpp_arg.py::test_shared_ptr_alias_nonpython - RuntimeError: BEAKIN_WIP: convert_type() called. FAILED test_class_sh_disowning_mi.py::test_disown_base1_first[MI5-10-11-1] - RuntimeError: BEAKIN_WIP: convert_type() called. ================================================ 82 failed, 939 passed, 20 skipped in 4.02s ================================================ ```
Ralf W. Grosse-Kunstleve committedJul 6, 2024 Configuration menu - View commit details
-
Copy full SHA for 4114e97 - Browse repository at this point
Copy the full SHA 4114e97View commit details -
Remove pytest.skip("BAKEIN_BREAK: ...") in test_class_sh_mi_thunks.py…
… (tests still fail)
Ralf W. Grosse-Kunstleve committedJul 6, 2024 Configuration menu - View commit details
-
Copy full SHA for b201eec - Browse repository at this point
Copy the full SHA b201eecView commit details -
WIP: remove convert_type() call from loaded_as_shared_ptr()
Ralf W. Grosse-Kunstleve committedJul 6, 2024 Configuration menu - View commit details
-
Copy full SHA for eb15f1a - Browse repository at this point
Copy the full SHA eb15f1aView commit details
Commits on Jul 7, 2024
-
MESSY but success for: test_get_vec_size_raw_shared[get_drvd_as_base0…
…_raw_ptr-vec_size_base0_shared_ptr] scons -j 48 selected_test_cpp=test_class_sh_mi_thunks.cpp && "$(cat PYROOT)"/bin/python3 $HOME/clone/pybind11_scons/run_tests.py ../pybind11 test_class_sh_mi_thunks.py -s -vv -k 'test_get_vec_size_raw_shared[get_drvd_as_base0_raw_ptr-vec_size_base0_shared_ptr]' ``` =========================================================== test session starts ============================================================ platform linux -- Python 3.11.8, pytest-7.4.4, pluggy-1.5.0 -- /usr/bin/python3 cachedir: .pytest_cache C++ Info: 13.2.0 C++20 __pybind11_internals_v10000000_gcc_libstdcpp_cxxabi1018__ PYBIND11_SIMPLE_GIL_MANAGEMENT=False PYBIND11_NUMPY_1_ONLY=False rootdir: /usr/local/google/home/rwgk/forked/pybind11/tests configfile: pytest.ini plugins: xdist-3.5.0 collected 10 items / 9 deselected / 1 selected test_class_sh_mi_thunks.py::test_get_vec_size_raw_shared[get_drvd_as_base0_raw_ptr-vec_size_base0_shared_ptr] LOOOK A LOOOK get raw drvd 47927280 LOOOK get raw base 47927312 LOOOK B LOOOK shd load(src, convert) X LOOOK shd try_implicit_casts(src, convert) Q LOOOK shd try_implicit_casts(src, convert) R LOOOK shd load(src, convert) X LOOOK shd load_value(v_h) ENTRY LOOOK shd load_value(v_h) A LOOOK shd load_value(v_h) B LOOOK shd load(src, convert) Y 47927280 LOOOK shd try_implicit_casts(src, convert) S LOOOK shd load(src, convert) Y 47927312 LOOOK operator std::shared_ptr<type> & A 47927312 /usr/local/google/home/rwgk/forked/pybind11/include/pybind11/detail/../cast.h:891 LOOOK /usr/local/google/home/rwgk/forked/pybind11/include/pybind11/detail/../detail/type_caster_base.h:838 LOOOK /usr/local/google/home/rwgk/forked/pybind11/include/pybind11/detail/../detail/type_caster_base.h:842 LOOOK operator std::shared_ptr<type> & B 47927312 /usr/local/google/home/rwgk/forked/pybind11/include/pybind11/detail/../cast.h:893 LOOOK shd const Base0 *obj 47927312 LOOOK shd const auto *obj_der 47927280 LOOOK C PASSED ===================================================== 1 passed, 9 deselected in 0.01s ====================================================== ```
Ralf W. Grosse-Kunstleve committedJul 7, 2024 Configuration menu - View commit details
-
Copy full SHA for bb6b429 - Browse repository at this point
Copy the full SHA bb6b429View commit details -
Clean out dead-end and debug code.
Ralf W. Grosse-Kunstleve committedJul 7, 2024 Configuration menu - View commit details
-
Copy full SHA for 1fbc4a2 - Browse repository at this point
Copy the full SHA 1fbc4a2View commit details -
Micro-scale cleanup/consolidation.
Ralf W. Grosse-Kunstleve committedJul 7, 2024 Configuration menu - View commit details
-
Copy full SHA for 103666a - Browse repository at this point
Copy the full SHA 103666aView commit details -
Pass thunk-corrected pointer to loaded_as_unique_ptr(). With this all…
… test_class_sh_mi_thunks tests pass.
Ralf W. Grosse-Kunstleve committedJul 7, 2024 Configuration menu - View commit details
-
Copy full SHA for 042ea81 - Browse repository at this point
Copy the full SHA 042ea81View commit details -
Remove
pytest.skip("BAKEIN_BREAK: ...")
in test_class_sh_disowning_……mi.py (tests pass without any further changes).
Ralf W. Grosse-Kunstleve committedJul 7, 2024 Configuration menu - View commit details
-
Copy full SHA for 1158dbc - Browse repository at this point
Copy the full SHA 1158dbcView commit details -
Bug fix:
typeid(cpptype)
->cpptype->name()
Ralf W. Grosse-Kunstleve committedJul 7, 2024 Configuration menu - View commit details
-
Copy full SHA for bd37d69 - Browse repository at this point
Copy the full SHA bd37d69View commit details -
test_class_sh_disowning.py: BAKEIN_WIP: Why is the behavior different?
Ralf W. Grosse-Kunstleve committedJul 7, 2024 Configuration menu - View commit details
-
Copy full SHA for 011c795 - Browse repository at this point
Copy the full SHA 011c795View commit details -
Clean out debug code in test_class_sh_mi_thunks.cpp,py
Ralf W. Grosse-Kunstleve committedJul 7, 2024 Configuration menu - View commit details
-
Copy full SHA for 56019a2 - Browse repository at this point
Copy the full SHA 56019a2View commit details -
Resolve clang-tidy errors and warnings.
Ralf W. Grosse-Kunstleve committedJul 7, 2024 Configuration menu - View commit details
-
Copy full SHA for b82892a - Browse repository at this point
Copy the full SHA b82892aView commit details -
Add
pytest.skip("BAKEIN_BREAK: ...)
in test_class_sh_shared_ptr_cop……y_move.py `test_properties()` (appears to fail on ~17 platforms).
Ralf W. Grosse-Kunstleve committedJul 7, 2024 Configuration menu - View commit details
-
Copy full SHA for 89c58c4 - Browse repository at this point
Copy the full SHA 89c58c4View commit details -
Merge branch 'master' into bakein
Ralf W. Grosse-Kunstleve committedJul 7, 2024 Configuration menu - View commit details
-
Copy full SHA for 7fc2ef4 - Browse repository at this point
Copy the full SHA 7fc2ef4View commit details -
Remove cruft from
smart_holder_type_caster_support::load_helper<>
Ralf W. Grosse-Kunstleve committedJul 7, 2024 Configuration menu - View commit details
-
Copy full SHA for f1f0eef - Browse repository at this point
Copy the full SHA f1f0eefView commit details -
Move
pytest.skip("BAKEIN_BREAK: ...)
in test_class_sh_shared_ptr_co……py_move.py to top level (still appears to fail on ~17 platforms).
Ralf W. Grosse-Kunstleve committedJul 7, 2024 Configuration menu - View commit details
-
Copy full SHA for c453013 - Browse repository at this point
Copy the full SHA c453013View commit details -
Bring in tests/test_class_sh_property.cpp,py from smart_holder branch…
… as-is (does not build).
Ralf W. Grosse-Kunstleve committedJul 7, 2024 Configuration menu - View commit details
-
Copy full SHA for c7bd78c - Browse repository at this point
Copy the full SHA c7bd78cView commit details -
Add
BAKEIN_BREAK
in test_class_sh_property.cpp,pyRalf W. Grosse-Kunstleve committedJul 7, 2024 Configuration menu - View commit details
-
Copy full SHA for b89ec00 - Browse repository at this point
Copy the full SHA b89ec00View commit details -
Bring in tests/test_class_sh_property_non_owning.cpp,py from smart_ho…
…lder branch as-is (does not build).
Ralf W. Grosse-Kunstleve committedJul 7, 2024 Configuration menu - View commit details
-
Copy full SHA for f52456e - Browse repository at this point
Copy the full SHA f52456eView commit details -
Add
BAKEIN_BREAK
in test_class_sh_property_non_owning.cpp,pyRalf W. Grosse-Kunstleve committedJul 7, 2024 Configuration menu - View commit details
-
Copy full SHA for ac055a4 - Browse repository at this point
Copy the full SHA ac055a4View commit details -
Bring in tests/test_classh_mock.cpp,py from smart_holder branch as-is…
… (tests pass without any further changes).
Ralf W. Grosse-Kunstleve committedJul 7, 2024 Configuration menu - View commit details
-
Copy full SHA for 9e3bee0 - Browse repository at this point
Copy the full SHA 9e3bee0View commit details -
Bring in tests/*class_sh_module_local* from smart_holder branch as-is…
… (tests pass without any further changes).
Ralf W. Grosse-Kunstleve committedJul 7, 2024 Configuration menu - View commit details
-
Copy full SHA for 68c9d13 - Browse repository at this point
Copy the full SHA 68c9d13View commit details -
Disable for now (to be debugged later): CI / 🐍 3 • GCC 7 • C++17• x64
Ralf W. Grosse-Kunstleve committedJul 7, 2024 Configuration menu - View commit details
-
Copy full SHA for 91d4003 - Browse repository at this point
Copy the full SHA 91d4003View commit details
Commits on Jul 8, 2024
-
test_class_sh_property_non_owning.py appears to cause memory corrupti…
…on leading to failures in test_class_sh_shared_ptr_copy_move.py: * Disable all tests in test_class_sh_property_non_owning.py * Disable only `test_properties()` in test_class_sh_shared_ptr_copy_move.py * Go back to original .github/workflows/ci.yml
Ralf W. Grosse-Kunstleve committedJul 8, 2024 Configuration menu - View commit details
-
Copy full SHA for cc86fb3 - Browse repository at this point
Copy the full SHA cc86fb3View commit details -
Add two
pytest.skip("BAKEIN_BREAK: Segmentation fault")
in test_cla……ss_sh_shared_ptr_copy_move.py (suspected (!) holder mismatch).
Ralf W. Grosse-Kunstleve committedJul 8, 2024 Configuration menu - View commit details
-
Copy full SHA for 3ddfc58 - Browse repository at this point
Copy the full SHA 3ddfc58View commit details -
Add two more
pytest.skip("BAKEIN_BREAK: Segmentation fault")
in tes……t_class_sh_shared_ptr_copy_move.py
Ralf W. Grosse-Kunstleve committedJul 8, 2024 Configuration menu - View commit details
-
Copy full SHA for 625c88b - Browse repository at this point
Copy the full SHA 625c88bView commit details
Commits on Jul 9, 2024
-
Stress test: use PYBIND11_SMART_HOLDER_PADDING unconditionally.
Ralf W. Grosse-Kunstleve committedJul 9, 2024 Configuration menu - View commit details
-
Copy full SHA for 0296d33 - Browse repository at this point
Copy the full SHA 0296d33View commit details -
SegFault 20.04 C++11 MinSizeRel all tests, but only first pass after …
…git clean -fdx NO SegFault 20.04 C++11 Debug all tests, even in first pass after git clean -fdx BUT then suddenly SegFaults not reproducible anymore even with MinSizeRel!? Current thread 0x00007f6c7165e740 (most recent call first): File "/mounted_pybind11/tests/test_class_sh_shared_ptr_copy_move.py", line 9 in test_shptr_copy line 9: lst = m.test_ShPtr_copy() This line was added after last observed SegFault del mth
Ralf W. Grosse-Kunstleve committedJul 9, 2024 Configuration menu - View commit details
-
Copy full SHA for 752626d - Browse repository at this point
Copy the full SHA 752626dView commit details -
pytest.skip() right before m.disown_b(...) in test_class_sh_property_…
…non_owning.py. Remove pytest.skip() in test_class_sh_shared_ptr_copy_move.py and test_class_sh_property_non_owning.py
Ralf W. Grosse-Kunstleve committedJul 9, 2024 Configuration menu - View commit details
-
Copy full SHA for 5a4442f - Browse repository at this point
Copy the full SHA 5a4442fView commit details -
Pull in from smart_holder branch: Additional
assert is_disowned()
i……n test_class_sh_disowning.py (pybind#5234)
Ralf W. Grosse-Kunstleve committedJul 9, 2024 Configuration menu - View commit details
-
Copy full SHA for c0f5078 - Browse repository at this point
Copy the full SHA c0f5078View commit details -
Transfer test_mixed from test_class_sh_disowning to test_wip (prepara…
…tion for debugging behavior difference).
Ralf W. Grosse-Kunstleve committedJul 9, 2024 Configuration menu - View commit details
-
Copy full SHA for c527814 - Browse repository at this point
Copy the full SHA c527814View commit details -
Ralf W. Grosse-Kunstleve committed
Jul 9, 2024 Configuration menu - View commit details
-
Copy full SHA for 36bbac1 - Browse repository at this point
Copy the full SHA 36bbac1View commit details -
Call new load_helper.get_void_ptr_or_nullptr() instead of calling typ…
…e_caster_generic::load_value() in shared_ptr and unique_ptr casters.
Ralf W. Grosse-Kunstleve committedJul 9, 2024 Configuration menu - View commit details
-
Copy full SHA for c6a87e8 - Browse repository at this point
Copy the full SHA c6a87e8View commit details -
Restore original test_class_sh_disowning.py from smart_holder branch.
Ralf W. Grosse-Kunstleve committedJul 9, 2024 Configuration menu - View commit details
-
Copy full SHA for e254264 - Browse repository at this point
Copy the full SHA e254264View commit details -
Remove all LOOOK in type_caster_base.h
Ralf W. Grosse-Kunstleve committedJul 9, 2024 Configuration menu - View commit details
-
Copy full SHA for 5759190 - Browse repository at this point
Copy the full SHA 5759190View commit details
Commits on Jul 10, 2024
-
Ralf W. Grosse-Kunstleve committed
Jul 10, 2024 Configuration menu - View commit details
-
Copy full SHA for 1ea3855 - Browse repository at this point
Copy the full SHA 1ea3855View commit details -
Reducing 2: rename C++ namespace from class_sh_disowning_mi to wip.
Ralf W. Grosse-Kunstleve committedJul 10, 2024 Configuration menu - View commit details
-
Copy full SHA for d3537e4 - Browse repository at this point
Copy the full SHA d3537e4View commit details -
Ralf W. Grosse-Kunstleve committed
Jul 10, 2024 Configuration menu - View commit details
-
Copy full SHA for 7e1eced - Browse repository at this point
Copy the full SHA 7e1ecedView commit details -
Restore test_class_sh_disowning_mi.cpp,py as it last worked with GHA …
…(commit 5759190).
Ralf W. Grosse-Kunstleve committedJul 10, 2024 Configuration menu - View commit details
-
Copy full SHA for f855283 - Browse repository at this point
Copy the full SHA f855283View commit details -
Replace
loaded_v_h.type = get_type_info(typeid(type))
with `loaded_……v_h.type = typeinfo` in `unique_ptr` `type_caster` and remove `pytest.skip()` in test_class_sh_disowning_mi.py
Ralf W. Grosse-Kunstleve committedJul 10, 2024 Configuration menu - View commit details
-
Copy full SHA for 127058c - Browse repository at this point
Copy the full SHA 127058cView commit details -
Copy code
property_cpp_function<>
code from smart_holder branch as-……is. Ifdef out all but the "classic" implementation.
Ralf W. Grosse-Kunstleve committedJul 10, 2024 Configuration menu - View commit details
-
Copy full SHA for f852cf5 - Browse repository at this point
Copy the full SHA f852cf5View commit details -
First pass adapting all
property_cpp_function<>
implementations. St……ill needs debugging and more testing: ``` ========================================================= short test summary info ========================================================== SKIPPED [2] test_class_sh_property.py:19: BAKEIN_BREAK: Failed: DID NOT RAISE <class 'ValueError'> SKIPPED [1] test_class_sh_property.py:87: BAKEIN_BREAK: m_uqcp_readwrite does not build SKIPPED [1] test_class_sh_property.py:140: BAKEIN_BREAK: m_uqmp_readwrite does not build SKIPPED [1] test_class_sh_property.py:140: BAKEIN_BREAK: m_uqcp_readwrite does not build SKIPPED [1] test_class_sh_basic.py:156: unconditional skip SKIPPED [1] test_class_sh_property.py:87: BAKEIN_BREAK: m_uqmp_readwrite does not build SKIPPED [1] test_stl.py:149: no <experimental/optional> SKIPPED [1] test_smart_ptr.py:301: BAKEIN_EXPECTED: Failed: DID NOT RAISE <class 'RuntimeError'> FAILED test_class_sh_property_non_owning.py::test_core_fld_common[core_fld_value_rw-expected1-True] - RuntimeError: Non-owning holder (loaded_as_shared_ptr). FAILED test_class_sh_property_non_owning.py::test_core_fld_common[core_fld_value_rw-expected1-False] - RuntimeError: Non-owning holder (loaded_as_shared_ptr). FAILED test_class_sh_property_non_owning.py::test_core_fld_common[core_fld_value_ro-expected0-True] - RuntimeError: Non-owning holder (loaded_as_shared_ptr). FAILED test_class_sh_property_non_owning.py::test_core_fld_common[core_fld_raw_ptr_ro-expected4-True] - RuntimeError: Non-owning holder (loaded_as_shared_ptr). FAILED test_class_sh_property_non_owning.py::test_core_fld_common[core_fld_raw_ptr_ro-expected4-False] - RuntimeError: Non-owning holder (loaded_as_shared_ptr). FAILED test_class_sh_property_non_owning.py::test_core_fld_common[core_fld_raw_ptr_rw-expected5-True] - RuntimeError: Non-owning holder (loaded_as_shared_ptr). FAILED test_class_sh_property_non_owning.py::test_core_fld_common[core_fld_value_ro-expected0-False] - RuntimeError: Non-owning holder (loaded_as_shared_ptr). FAILED test_class_sh_property_non_owning.py::test_core_fld_common[core_fld_raw_ptr_rw-expected5-False] - RuntimeError: Non-owning holder (loaded_as_shared_ptr). ================================================ 8 failed, 1056 passed, 9 skipped in 3.96s ================================================= ```
Ralf W. Grosse-Kunstleve committedJul 10, 2024 Configuration menu - View commit details
-
Copy full SHA for 1bcf572 - Browse repository at this point
Copy the full SHA 1bcf572View commit details
Commits on Jul 12, 2024
-
Bring in
shared_ptr_with_responsible_parent()
from smart_holder bra……nch: smart_holder branch: ``` static std::shared_ptr<type> shared_ptr_from_python(handle responsible_parent) ``` Renamed in this commit: ``` static std::shared_ptr<type> shared_ptr_with_responsible_parent(handle responsible_parent) ``` Use in `property_cpp_function<>` specializations. Fixes all 8 test failures introduced with the previous commit (1bcf572): ``` FAILED test_class_sh_property_non_owning.py::test_core_fld_common[core_fld_value_ro-expected0-True] - RuntimeError: Non-owning holder (loaded_as_shared_ptr). FAILED test_class_sh_property_non_owning.py::test_core_fld_common[core_fld_value_rw-expected1-True] - RuntimeError: Non-owning holder (loaded_as_shared_ptr). FAILED test_class_sh_property_non_owning.py::test_core_fld_common[core_fld_value_rw-expected1-False] - RuntimeError: Non-owning holder (loaded_as_shared_ptr). FAILED test_class_sh_property_non_owning.py::test_core_fld_common[core_fld_raw_ptr_ro-expected4-True] - RuntimeError: Non-owning holder (loaded_as_shared_ptr). FAILED test_class_sh_property_non_owning.py::test_core_fld_common[core_fld_raw_ptr_ro-expected4-False] - RuntimeError: Non-owning holder (loaded_as_shared_ptr). FAILED test_class_sh_property_non_owning.py::test_core_fld_common[core_fld_raw_ptr_rw-expected5-True] - RuntimeError: Non-owning holder (loaded_as_shared_ptr). FAILED test_class_sh_property_non_owning.py::test_core_fld_common[core_fld_value_ro-expected0-False] - RuntimeError: Non-owning holder (loaded_as_shared_ptr). FAILED test_class_sh_property_non_owning.py::test_core_fld_common[core_fld_raw_ptr_rw-expected5-False] - RuntimeError: Non-owning holder (loaded_as_shared_ptr). ```
Ralf W. Grosse-Kunstleve committedJul 12, 2024 Configuration menu - View commit details
-
Copy full SHA for 048e36d - Browse repository at this point
Copy the full SHA 048e36dView commit details -
test_class_sh_property.py
test_valu_getter()
works without any furt……her changes.
Ralf W. Grosse-Kunstleve committedJul 12, 2024 Configuration menu - View commit details
-
Copy full SHA for 0b14d5b - Browse repository at this point
Copy the full SHA 0b14d5bView commit details -
Remove remaining BAKEIN_BREAK in test_class_sh_property.cpp,py and ad…
…just (simplify) the `property_cpp_function<...unique_ptr...>::write` implementation (all tests pass). This PR (pybind#5213) at this commit also passes ASAN, MSAN, UBSAN testing with the Google-internal toolchain.
Ralf W. Grosse-Kunstleve committedJul 12, 2024 Configuration menu - View commit details
-
Copy full SHA for d373a08 - Browse repository at this point
Copy the full SHA d373a08View commit details -
Bring in
default_holder_type
from smart_holder branch including usi……ng it in pybind11/stl_bind.h
Ralf W. Grosse-Kunstleve committedJul 12, 2024 Configuration menu - View commit details
-
Copy full SHA for 63044cc - Browse repository at this point
Copy the full SHA 63044ccView commit details -
Remove redundant
check_holder_compat()
no-op implementation.Ralf W. Grosse-Kunstleve committedJul 12, 2024 Configuration menu - View commit details
-
Copy full SHA for d021bb1 - Browse repository at this point
Copy the full SHA d021bb1View commit details -
Remove test_wip.cpp,py (not needed anymore).
Ralf W. Grosse-Kunstleve committedJul 12, 2024 Configuration menu - View commit details
-
Copy full SHA for 092d236 - Browse repository at this point
Copy the full SHA 092d236View commit details
Commits on Jul 13, 2024
-
PYBIND11_HAVE_HOLDER_CASTER_WITH_SMART_HOLDER_SUPPORT
Introduce two helper types: * copyable_holder_caster_shared_ptr_with_smart_holder_support_enabled * move_only_holder_caster_unique_ptr_with_smart_holder_support_enabled
Ralf W. Grosse-Kunstleve committedJul 13, 2024 Configuration menu - View commit details
-
Copy full SHA for 6fa0a2e - Browse repository at this point
Copy the full SHA 6fa0a2eView commit details -
Remove test_ccccccccccccccccccccc.cpp,py (not needed anymore).
Ralf W. Grosse-Kunstleve committedJul 13, 2024 Configuration menu - View commit details
-
Copy full SHA for 2600bb6 - Browse repository at this point
Copy the full SHA 2600bb6View commit details
Commits on Jul 14, 2024
-
New test_class_sh_property_bakein.py
Use cases in the wild: * `test_readonly_char6_member()`: https://github.com/pytorch/pytorch/blob/4410c44ae6fd8eb36f2358ac76f7d988ca7537c5/torch/csrc/cuda/Module.cpp#L961 * `test_readonly_const_char_ptr_member()`: https://github.com/facebookresearch/nle/blob/862a439a84f52abca94d1f744d57061da12c5831/include/permonst.h#L43
Ralf W. Grosse-Kunstleve committedJul 14, 2024 Configuration menu - View commit details
-
Copy full SHA for 3406be6 - Browse repository at this point
Copy the full SHA 3406be6View commit details -
Systematically use
is_base_of<type_caster_generic, make_caster<D>>
……in `property_cpp_function<>` specializations.
Ralf W. Grosse-Kunstleve committedJul 14, 2024 Configuration menu - View commit details
-
Copy full SHA for c65d5df - Browse repository at this point
Copy the full SHA c65d5dfView commit details -
Use
memcpy
instead ofstrcpy
to resolve MSVC errors.Ralf W. Grosse-Kunstleve committedJul 14, 2024 Configuration menu - View commit details
-
Copy full SHA for 89da1e2 - Browse repository at this point
Copy the full SHA 89da1e2View commit details
Commits on Jul 15, 2024
-
Introduce
detail::both_t_and_d_use_type_caster_base<T, D>
helper an……d use systematically in all `property_cpp_function<>` specializations. This fixes a PyTorch build error (using the Google-internal toolchain): ``` In file included from third_party/py/torch/torch/csrc/distributed/c10d/init.cpp:15: In file included from third_party/py/torch/torch/csrc/distributed/c10d/PyProcessGroup.hpp:4: In file included from third_party/py/torch/torch/csrc/jit/python/pybind_utils.h:7: In file included from third_party/pybind11/include/pybind11/complex.h:14: In file included from third_party/pybind11/include/pybind11/pybind11.h:14: In file included from third_party/pybind11/include/pybind11/detail/class.h:14: In file included from third_party/pybind11/include/pybind11/detail/../attr.h:16: third_party/pybind11/include/pybind11/detail/../cast.h:856:19: error: static assertion failed due to requirement 'std::is_base_of<pybind11::detail::type_caster_base<c10::intrusive_ptr<c10d::Store, c10::detail::intrusive_target_default_null_type<c10d::Store>>>, pybind11::detail::type_caster<c10::intrusive_ptr<c10d::Store, c10::detail::intrusive_target_default_null_type<c10d::Store>>, void>>::value': Holder classes are only supported for custom types 856 | static_assert(std::is_base_of<base, type_caster<type>>::value, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ third_party/pybind11/include/pybind11/detail/../cast.h:982:48: note: in instantiation of template class 'pybind11::detail::copyable_holder_caster<c10::intrusive_ptr<c10d::Store>, std::shared_ptr<c10::intrusive_ptr<c10d::Store>>>' requested here 982 | class type_caster<std::shared_ptr<T>> : public copyable_holder_caster<T, std::shared_ptr<T>> {}; | ^ third_party/crosstool/v18/stable/src/libcxx/include/__type_traits/is_base_of.h:22:91: note: in instantiation of template class 'pybind11::detail::type_caster<std::shared_ptr<c10::intrusive_ptr<c10d::Store>>>' requested here 22 | struct _LIBCPP_TEMPLATE_VIS is_base_of : public integral_constant<bool, __is_base_of(_Bp, _Dp)> {}; | ^ third_party/pybind11/include/pybind11/detail/../cast.h:1382:30: note: in instantiation of template class 'std::is_base_of<pybind11::detail::type_caster_generic, pybind11::detail::type_caster<std::shared_ptr<c10::intrusive_ptr<c10d::Store>>>>' requested here 1382 | detail::enable_if_t<std::is_base_of<type_caster_generic, make_caster<Return>>::value, void>> { | ^ third_party/pybind11/include/pybind11/pybind11.h:287:19: note: during template argument deduction for class template partial specialization 'return_value_policy_override<Return, detail::enable_if_t<std::is_base_of<type_caster_generic, make_caster<Return>>::value, void>>' [with Return = std::shared_ptr<c10::intrusive_ptr<c10d::Store>>] 287 | = return_value_policy_override<Return>::policy(call.func.policy); | ^ third_party/pybind11/include/pybind11/pybind11.h:287:19: note: in instantiation of template class 'pybind11::detail::return_value_policy_override<std::shared_ptr<c10::intrusive_ptr<c10d::Store>>>' requested here third_party/pybind11/include/pybind11/pybind11.h:269:55: note: while substituting into a lambda expression here 269 | rec->impl = [](function_call &call) -> handle { | ^ third_party/pybind11/include/pybind11/pybind11.h:147:9: note: in instantiation of function template specialization 'pybind11::cpp_function::initialize<(lambda at third_party/pybind11/include/pybind11/pybind11.h:1714:17), std::shared_ptr<c10::intrusive_ptr<c10d::Store>>, pybind11::handle, pybind11::is_method>' requested here 147 | initialize( | ^ third_party/pybind11/include/pybind11/pybind11.h:1713:20: note: in instantiation of function template specialization 'pybind11::cpp_function::cpp_function<(lambda at third_party/pybind11/include/pybind11/pybind11.h:1714:17), pybind11::is_method, void>' requested here 1713 | return cpp_function( | ^ third_party/pybind11/include/pybind11/pybind11.h:1964:54: note: in instantiation of function template specialization 'pybind11::property_cpp_function<c10d::DistributedBackendOptions, c10::intrusive_ptr<c10d::Store>>::read<c10::intrusive_ptr<c10d::Store> c10d::DistributedBackendOptions::*, 0>' requested here 1964 | property_cpp_function<type, D>::read(pm, *this), | ^ third_party/py/torch/torch/csrc/distributed/c10d/init.cpp:945:8: note: in instantiation of function template specialization 'pybind11::class_<c10d::DistributedBackendOptions>::def_readwrite<c10d::DistributedBackendOptions, c10::intrusive_ptr<c10d::Store>>' requested here 945 | .def_readwrite("store", &::c10d::DistributedBackendOptions::store) | ^ 1 error generated. ```
Ralf W. Grosse-Kunstleve committedJul 15, 2024 Configuration menu - View commit details
-
Copy full SHA for ff3693f - Browse repository at this point
Copy the full SHA ff3693fView commit details -
Move
must_be_member_function_pointer
to thedetail
namespace.Ralf W. Grosse-Kunstleve committedJul 15, 2024 Configuration menu - View commit details
-
Copy full SHA for 0f874de - Browse repository at this point
Copy the full SHA 0f874deView commit details -
Add
"_sh_baked_in"
toPYBIND11_INTERNALS_ID
, `PYBIND11_MODULE_LOC……AL_ID`
Ralf W. Grosse-Kunstleve committedJul 15, 2024 Configuration menu - View commit details
-
Copy full SHA for 884305e - Browse repository at this point
Copy the full SHA 884305eView commit details -
smart_holder_from_unique_ptr
: also accept `return_value_policy::ref……erence` There are no strong reasons for accepting or rejecting `return_value_policy::reference`. Accepting to accommodate existing use cases in the wild.
Ralf W. Grosse-Kunstleve committedJul 15, 2024 Configuration menu - View commit details
-
Copy full SHA for 12f384b - Browse repository at this point
Copy the full SHA 12f384bView commit details -
smart_holder_from_unique_ptr
: also accept `return_value_policy::tak……e_ownership` There are no strong reasons for accepting or rejecting `return_value_policy::take_ownership`. Accepting to accommodate existing use cases in the wild.
Ralf W. Grosse-Kunstleve committedJul 15, 2024 Configuration menu - View commit details
-
Copy full SHA for ecd01da - Browse repository at this point
Copy the full SHA ecd01daView commit details
Commits on Jul 16, 2024
-
Merge branch 'master' into bakein
Ralf W. Grosse-Kunstleve committedJul 16, 2024 Configuration menu - View commit details
-
Copy full SHA for ed27c37 - Browse repository at this point
Copy the full SHA ed27c37View commit details
Commits on Jul 18, 2024
-
Merge branch 'master' into bakein
Ralf W. Grosse-Kunstleve committedJul 18, 2024 Configuration menu - View commit details
-
Copy full SHA for 8ca5593 - Browse repository at this point
Copy the full SHA 8ca5593View commit details -
Factor out detail/value_and_holder.h (from detail/type_caster_base.h)
This is in support of PR pybind#5213: * trampoline_self_life_support.h depends on value_and_holder.h * type_caster_base.h depends on trampoline_self_life_support.h
Ralf W. Grosse-Kunstleve committedJul 18, 2024 Configuration menu - View commit details
-
Copy full SHA for 5e30064 - Browse repository at this point
Copy the full SHA 5e30064View commit details -
Fix a minor and inconsequential inconsistency in `copyable_holder_cas…
…ter`: the correct `load_value()` return type is `void` (as defined in `type_caster_generic`) For easy future reference, this is the long-standing inconsistency: * https://github.com/pybind/pybind11/blob/dbf848aff7c37ef8798bc9459a86193e28b1032f/include/pybind11/detail/type_caster_base.h#L634 * https://github.com/pybind/pybind11/blob/dbf848aff7c37ef8798bc9459a86193e28b1032f/include/pybind11/cast.h#L797 Noticed in passing while working on PR pybind#5213.
Ralf W. Grosse-Kunstleve committedJul 18, 2024 Configuration menu - View commit details
-
Copy full SHA for 54fd559 - Browse repository at this point
Copy the full SHA 54fd559View commit details -
Merge branch 'bakein_prep_on_master' into bakein
Ralf W. Grosse-Kunstleve committedJul 18, 2024 Configuration menu - View commit details
-
Copy full SHA for 7fa6dd9 - Browse repository at this point
Copy the full SHA 7fa6dd9View commit details -
Leverage PR pybind#5251 to bring back trampoline_self_life_support.h …
…from smart_holder branch almost as-is. This ensures IWYU correctness in client code. The only change in trampoline_self_life_support.h is to replace `#include "detail/type_caster_base.h"` with "#include detail/value_and_holder.h".
Ralf W. Grosse-Kunstleve committedJul 18, 2024 Configuration menu - View commit details
-
Copy full SHA for 9a27e29 - Browse repository at this point
Copy the full SHA 9a27e29View commit details -
Undo
DANGER ZONE
comment (brought in from smart_holder branch; befo……re adding to PR pybind#5251).
Ralf W. Grosse-Kunstleve committedJul 18, 2024 Configuration menu - View commit details
-
Copy full SHA for 1ca810e - Browse repository at this point
Copy the full SHA 1ca810eView commit details -
Add
DANGER ZONE
comment in detail/init.h, similar to a comment adde……d on the smart_holder branch (all the way back in 2021).
Ralf W. Grosse-Kunstleve committedJul 18, 2024 Configuration menu - View commit details
-
Copy full SHA for 92d7724 - Browse repository at this point
Copy the full SHA 92d7724View commit details -
Merge branch 'bakein_prep_on_master' into bakein
Ralf W. Grosse-Kunstleve committedJul 18, 2024 Configuration menu - View commit details
-
Copy full SHA for 4aa2f6b - Browse repository at this point
Copy the full SHA 4aa2f6bView commit details
Commits on Jul 19, 2024
-
Merge branch 'master' into bakein
Ralf W. Grosse-Kunstleve committedJul 19, 2024 Configuration menu - View commit details
-
Copy full SHA for 6d8952a - Browse repository at this point
Copy the full SHA 6d8952aView commit details -
Remove overlooked BAKEIN_BREAK in test_class_sh_property_non_owning.c…
…pp,py (tests pass without any further changes).
Ralf W. Grosse-Kunstleve committedJul 19, 2024 Configuration menu - View commit details
-
Copy full SHA for 1ea1787 - Browse repository at this point
Copy the full SHA 1ea1787View commit details -
PYBIND11_HAVE_INTERNALS_WITH_SMART_HOLDER_SUPPORT
Ralf W. Grosse-Kunstleve committedJul 19, 2024 Configuration menu - View commit details
-
Copy full SHA for cd4f5f6 - Browse repository at this point
Copy the full SHA cd4f5f6View commit details -
Reinterpret
detail::type_info::default_holder
as "uses `std::unique……_ptr` holder" (which is the original meaning, and compatible with the original smart_holder branch).
Ralf W. Grosse-Kunstleve committedJul 19, 2024 Configuration menu - View commit details
-
Copy full SHA for 58a1b75 - Browse repository at this point
Copy the full SHA 58a1b75View commit details -
Use
std::unique_ptr<T>
as default holder again.Ralf W. Grosse-Kunstleve committedJul 19, 2024 Configuration menu - View commit details
-
Copy full SHA for 583c07b - Browse repository at this point
Copy the full SHA 583c07bView commit details -
Introduce detail/using_smart_holder.h and remove
pybindit::memory::
…… in most places.
Ralf W. Grosse-Kunstleve committedJul 19, 2024 Configuration menu - View commit details
-
Copy full SHA for 7296c39 - Browse repository at this point
Copy the full SHA 7296c39View commit details -
Bring in ci.yml, ci_sh_def.yml, ci_sh_def.yml.patch from smart_holder…
… branch as-is.
Ralf W. Grosse-Kunstleve committedJul 19, 2024 Configuration menu - View commit details
-
Copy full SHA for cc2a428 - Browse repository at this point
Copy the full SHA cc2a428View commit details -
Add back original
copyable_holder_caster
check_holder_compat()
in…… the `std::shared_ptr` specialization and remove `pytest.skip("BAKEIN_EXPECTED: ...)` in test_smart_ptr.py
Ralf W. Grosse-Kunstleve committedJul 19, 2024 Configuration menu - View commit details
-
Copy full SHA for 6fb8b51 - Browse repository at this point
Copy the full SHA 6fb8b51View commit details -
Boilerplate changes: Skip all test_class_sh_* if PYBIND11_HAVE_INTERN…
…ALS_WITH_SMART_HOLDER_SUPPORT is not defined.
Ralf W. Grosse-Kunstleve committedJul 19, 2024 Configuration menu - View commit details
-
Copy full SHA for 95e9053 - Browse repository at this point
Copy the full SHA 95e9053View commit details -
Ignore PYBIND11_USE_SMART_HOLDER_AS_DEFAULT if PYBIND11_HAVE_INTERNAL…
…S_WITH_SMART_HOLDER_SUPPORT is not defined.
Ralf W. Grosse-Kunstleve committedJul 19, 2024 Configuration menu - View commit details
-
Copy full SHA for e445619 - Browse repository at this point
Copy the full SHA e445619View commit details -
ifdef out classh if PYBIND11_HAVE_INTERNALS_WITH_SMART_HOLDER_SUPPORT…
… is not defined.
Ralf W. Grosse-Kunstleve committedJul 19, 2024 Configuration menu - View commit details
-
Copy full SHA for 41433f6 - Browse repository at this point
Copy the full SHA 41433f6View commit details -
ifdef out more code if PYBIND11_HAVE_INTERNALS_WITH_SMART_HOLDER_SUPP…
…ORT is not defined.
Ralf W. Grosse-Kunstleve committedJul 19, 2024 Configuration menu - View commit details
-
Copy full SHA for 4a66b46 - Browse repository at this point
Copy the full SHA 4a66b46View commit details
Commits on Jul 20, 2024
-
Revert "Add
"_sh_baked_in"
toPYBIND11_INTERNALS_ID
, `PYBIND11_MO……DULE_LOCAL_ID`" `"_sh_baked_in"` is no longer needed because the smart_holder functionality is now tied to the `PYBIND11_INTERNALS_VERSION`. This reverts commit 884305e.
Ralf W. Grosse-Kunstleve committedJul 20, 2024 Configuration menu - View commit details
-
Copy full SHA for 62b6c8e - Browse repository at this point
Copy the full SHA 62b6c8eView commit details -
Small cleanup in detail/init.h: strip `originally_smart_holder_type_c…
…asters_h` namespace.
Ralf W. Grosse-Kunstleve committedJul 20, 2024 Configuration menu - View commit details
-
Copy full SHA for 35b1177 - Browse repository at this point
Copy the full SHA 35b1177View commit details -
Move
try_initialization_using_shared_from_this
into `PYBIND11_HAVE_……INTERNALS_WITH_SMART_HOLDER_SUPPORT` block.
Ralf W. Grosse-Kunstleve committedJul 20, 2024 Configuration menu - View commit details
-
Copy full SHA for 5566c63 - Browse repository at this point
Copy the full SHA 5566c63View commit details -
Introduce PYBIND11_SMART_HOLDER_PADDING_ON (as the only way to turn o…
…n padding).
Ralf W. Grosse-Kunstleve committedJul 20, 2024 Configuration menu - View commit details
-
Copy full SHA for df54a82 - Browse repository at this point
Copy the full SHA df54a82View commit details -
Import pybind#5256 from smart_holder branch back here (same test code…
… as in test_class_sh_property_bakein.cpp,py).
Ralf W. Grosse-Kunstleve committedJul 20, 2024 Configuration menu - View commit details
-
Copy full SHA for 84f71f1 - Browse repository at this point
Copy the full SHA 84f71f1View commit details -
Remove redundant test_class_sh_property_bakein.cpp,py
Ralf W. Grosse-Kunstleve committedJul 20, 2024 Configuration menu - View commit details
-
Copy full SHA for 9f9a698 - Browse repository at this point
Copy the full SHA 9f9a698View commit details
Commits on Jul 21, 2024
-
Move
classh
into pybind11/pybind11.h and update test_classh_mock.cp……p accordingly.
Ralf W. Grosse-Kunstleve committedJul 21, 2024 Configuration menu - View commit details
-
Copy full SHA for d0003f5 - Browse repository at this point
Copy the full SHA d0003f5View commit details -
test_class.cpp: simpler approach, leveraging new `PYBIND11_ACTUALLY_U…
…SING_SMART_HOLDER_AS_DEFAULT`
Ralf W. Grosse-Kunstleve committedJul 21, 2024 Configuration menu - View commit details
-
Copy full SHA for 89d0ddd - Browse repository at this point
Copy the full SHA 89d0dddView commit details -
Tie
PYBIND11_INTERNALS_VERSION 6
toPYBIND11_VERSION_MAJOR >= 3
Ralf W. Grosse-Kunstleve committedJul 21, 2024 Configuration menu - View commit details
-
Copy full SHA for 18b72c0 - Browse repository at this point
Copy the full SHA 18b72c0View commit details
Commits on Jul 22, 2024
-
Import non-functional test changes made on smart_holder branch under PR
Ralf W. Grosse-Kunstleve committedJul 22, 2024 Configuration menu - View commit details
-
Copy full SHA for c4c3d9a - Browse repository at this point
Copy the full SHA c4c3d9aView commit details