Apply suggestion by @isuruf, with revised comments (code is as sugges…

…ted).
pybind · Dec 3, 2024 · ca9e699 · ca9e699
1 parent e071edc
commit ca9e699
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/include/pybind11/conduit/pybind11_platform_abi_id.h b/include/pybind11/conduit/pybind11_platform_abi_id.h
@@ -23,8 +23,14 @@
 #        define PYBIND11_COMPILER_TYPE "gcc_cygwin"
 #    elif defined(_MSC_VER)
 #        define PYBIND11_COMPILER_TYPE "msvc"
-#    elif defined(__INTEL_COMPILER) || defined(__clang__) || defined(__GNUC__)
-#        define PYBIND11_COMPILER_TYPE "system" // Assumed compatible with system compiler.
+#    elif defined(__GLIBC__)                                                                      \
+        && (defined(__INTEL_COMPILER) || defined(__clang__) || defined(__GNUC__))
+//       // Compatibility is determined based on libstdc++ or libc++ ABI version (below).
+#        define PYBIND11_COMPILER_TYPE "glibc"
+#    elif defined(__APPLE__)                                                                      \
+        && (defined(__INTEL_COMPILER) || defined(__clang__) || defined(__GNUC__))
+//       // Compatibility is (usually) determined based on libc++ ABI version (below).
+#        define PYBIND11_COMPILER_TYPE "macos"
 #    else
 #        error "Unknown PYBIND11_COMPILER_TYPE: PLEASE REVISE THIS CODE."
 #    endif