-
-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Domain degradation parameters #4463
Draft
DrSOKane
wants to merge
28
commits into
pybamm-team:develop
Choose a base branch
from
DrSOKane:domain-degradation-parameters
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
0e70d3e
Started modifying porosity change submodel to work with phases
DrSOKane b8dd013
Porosity now works on composite electrode
DrSOKane e8fc8f4
Now works for non-composite electrode as well!
DrSOKane b2825de
Merge branch 'develop' of https://github.com/pybamm-team/PyBaMM into …
DrSOKane b76a2ca
style: pre-commit fixes
pre-commit-ci[bot] 6b87041
changelog
DrSOKane cd4aa54
Merge branch 'composite-porosity' of https://github.com/DrSOKane/PyBa…
DrSOKane 4758ab8
style fix
DrSOKane adcb652
Updated tests
DrSOKane 1985fb1
Changed how pref is handled
DrSOKane 9352297
Merge branch 'develop' of https://github.com/pybamm-team/PyBaMM into …
DrSOKane 709d634
Added comments to the new if statements
DrSOKane 96d960d
Merge branch 'develop' of https://github.com/pybamm-team/PyBaMM into …
DrSOKane f0a5a79
Why did I not think of this before?!
DrSOKane afb6f11
All SEI and plating parameters now have domains
DrSOKane 2f898c3
Merge branch 'develop' of https://github.com/pybamm-team/PyBaMM into …
DrSOKane d1ed350
Updated half-cell example notebook to showcase new capability
DrSOKane a61797a
Added Chen2020_composite_halfcell parameter set
DrSOKane 2af22e6
Fixed merge conflict in changelog
DrSOKane c987339
style: pre-commit fixes
pre-commit-ci[bot] 7e0d342
changelog
DrSOKane 571a0a0
Merge branch 'domain-degradation-parameters' of https://github.com/Dr…
DrSOKane a5303f3
Fixed tests and parameter names
DrSOKane bb75cb1
Updated example notebooks with new parameter names
DrSOKane 3cda3fe
style: pre-commit fixes
pre-commit-ci[bot] 2127d73
Fixed integration tests
DrSOKane 8d92999
Merge branch 'domain-degradation-parameters' of https://github.com/Dr…
DrSOKane 01ed5ed
All half-cell tests with SEI now use Ecker2015_halfcell parameters
DrSOKane File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR #4417 is still open this probably should not be in the log. Not sure if those changes are also in here, but we should probably either separate these PRs or close the other PR.