Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web and Spark SDK Changes To Enable Application Adoption [DO NOT MERGE] #10

Open
wants to merge 1 commit into
base: spark
Choose a base branch
from

Conversation

imrobertloucans
Copy link

What:

  • Various SDK modifications made in order to support application development and usage
  • adds editor config file to align IDEs with internal project code formatting standards
  • removes various references to uneeded libraries, components and utilities
  • removes various extraneous calls to metrological
  • removes hardcoded configuration options
  • aligns key press handling between spark and web
  • removes hardcoded background styles

Why:

  • These changes are for informational purposes only. They illustrate "first pass" changes an application team needed to make in order to effectively use the SDK to build an app that runs on both web and spark platforms using the Lightning SDK, Lightning++ and Lightning stack

    • NOTE: This was a first pass and does not represent an exhaustive analysis and design for the overall SDK structure.

    • NOTE: Not included are additional changes needed to the packaging process. These will be submitted in a separate PR.

mfiess pushed a commit to mfiess/Lightning-SDK that referenced this pull request Sep 11, 2019
…-app-crash

Hotfix for crash, when component outlives application.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant