Properly close channel container

pwojcikdev · Mar 16, 2024 · ef81c25 · ef81c25
1 parent db5f785
commit ef81c25
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/nano/node/transport/tcp.cpp b/nano/node/transport/tcp.cpp
@@ -150,7 +150,13 @@ void nano::transport::tcp_channels::stop ()
 
 	message_manager.stop ();
 
-	// Close all TCP sockets
+	close ();
+}
+
+void nano::transport::tcp_channels::close ()
+{
+	nano::lock_guard<nano::mutex> lock{ mutex };
+
 	for (auto const & channel : channels)
 	{
 		if (channel.socket)
@@ -163,6 +169,7 @@ void nano::transport::tcp_channels::stop ()
 			channel.response_server->stop ();
 		}
 	}
+
 	channels.clear ();
 }
 

diff --git a/nano/node/transport/tcp.hpp b/nano/node/transport/tcp.hpp
@@ -136,6 +136,7 @@ namespace transport
 		void start ();
 		void stop ();
 
+		void close ();
 		bool insert (std::shared_ptr<nano::transport::channel_tcp> const &, std::shared_ptr<nano::transport::socket> const &, std::shared_ptr<nano::transport::tcp_server> const &);
 		void erase (nano::tcp_endpoint const &);
 		std::size_t size () const;