Do not hold transaction in json_handler::blocks_info

pwojcikdev · Jan 17, 2024 · 0667b05 · 0667b05
1 parent 250ed20
commit 0667b05
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/nano/node/json_handler.cpp b/nano/node/json_handler.cpp
@@ -1295,11 +1295,15 @@ void nano::json_handler::blocks_info ()
 
 	boost::property_tree::ptree blocks;
 	boost::property_tree::ptree blocks_not_found;
-	auto transaction (node.store.tx_begin_read ());
-	for (boost::property_tree::ptree::value_type & hashes : request.get_child ("hashes"))
+
 	{
-		if (!ec)
+		auto transaction (node.store.tx_begin_read ());
+		for (boost::property_tree::ptree::value_type & hashes : request.get_child ("hashes"))
 		{
+			if (ec)
+			{
+				break;
+			}
 			std::string hash_text = hashes.second.data ();
 			nano::block_hash hash;
 			if (!hash.decode_hex (hash_text))