Fix webAppReport output #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
writeAndExit function
Fix error handling and exit process with
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to fix output bug on a big manifest files, as well as a removal of a URL from the
test_urls.jsonfile.Main code improvements:
Report/lighthouse/lighthouse.ts: Added a check for the existence ofwebAppReportbefore accessing its properties and used a newwriteAndExit()function for consistent handling of writing data to stdout and exiting the process. [1] [2]Test improvement:
tests/test_urls.json: Removed the URL "https://www.match.cards/" from the list of test URLs in thetest_urls.jsonfile.