Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add python 3.13 to test matrix #215

Merged
merged 3 commits into from
Dec 13, 2024
Merged

Add python 3.13 to test matrix #215

merged 3 commits into from
Dec 13, 2024

Conversation

kandersolar
Copy link
Member

@kandersolar kandersolar commented Oct 16, 2024 •
edited
Loading

  • Adds description and name entries in the appropriate "what's new" file
    in docs/whatsnew
    for all changes. Includes link to the GitHub Issue with :issue:`num`
    or this Pull Request with :pull:`num`. Includes contributor name
    and/or GitHub username (link with :ghuser:`user`).
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels and Milestone are assigned to the Pull Request and linked Issue.

@kandersolar
Copy link
Member Author

Looks like we can't merge this today; scikit-image isn't ready for python 3.13 quite yet.

@kandersolar kandersolar added this to the v0.2.3 milestone Nov 27, 2024
@kandersolar
Copy link
Member Author

Trying again now that scikit-image released a version that support python 3.13: https://pypi.org/project/scikit-image/0.25.0/#files

@kandersolar kandersolar reopened this Dec 13, 2024
@kandersolar kandersolar marked this pull request as ready for review December 13, 2024 21:46
@kandersolar kandersolar added tests Something is wrong with the test suite ci Continuous Integration labels Dec 13, 2024
@kandersolar
Copy link
Member Author

kandersolar commented Dec 13, 2024 •
edited
Loading

There is a new deprecation warning that I'll open a new issue for (#218), but otherwise the logs look good here so I'll go ahead and merge.

@kandersolar kandersolar merged commit 9aef5b5 into pvlib:main Dec 13, 2024
41 checks passed
@kandersolar kandersolar deleted the py313 branch December 13, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci Continuous Integration tests Something is wrong with the test suite
Projects
None yet
Milestone
v0.2.3
Development

Successfully merging this pull request may close these issues.
1 participant
@kandersolar