Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numpy 2.0 compatibility #211

Merged
merged 3 commits into from
Jun 25, 2024
Merged

Numpy 2.0 compatibility #211

merged 3 commits into from
Jun 25, 2024

Conversation

kandersolar
Copy link
Member

  • [ ] Closes #xxx
  • Added tests to cover all new or modified code.
  • [ ] Clearly documented all new API functions with PEP257 and numpydoc compliant docstrings.
  • [ ] Added new API functions to docs/api.rst.
  • [ ] Non-API functions clearly documented with docstrings or comments as necessary.
  • Adds description and name entries in the appropriate "what's new" file
    in docs/whatsnew
    for all changes. Includes link to the GitHub Issue with :issue:`num`
    or this Pull Request with :pull:`num`. Includes contributor name
    and/or GitHub username (link with :ghuser:`user`).
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels and Milestone are assigned to the Pull Request and linked Issue.

This PR adds compatibility for numpy 2.0, requiring minor changes (just NaN and Inf capitalization) to both the code base and the test suite.

@kandersolar kandersolar added enhancement New feature or request dependency Issues relating to dependencies or dependency management labels Jun 25, 2024
@kandersolar kandersolar added this to the v0.2.1 milestone Jun 25, 2024
Copy link
Member

@cwhanse cwhanse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @kandersolar

docs/whatsnew/0.2.1.rst Outdated Show resolved Hide resolved
@kandersolar kandersolar merged commit c144f6e into pvlib:main Jun 25, 2024
1 check was pending
@kandersolar kandersolar deleted the numpy-2.0 branch June 25, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency Issues relating to dependencies or dependency management enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants