Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minimum GHI limit check from Nollas et al. (2023) #174

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

AdamRJensen
Copy link
Member

@AdamRJensen AdamRJensen commented Nov 30, 2022

  • Closes Minimum GHI limit (QC check) #172
  • Added tests to cover all new or modified code.
  • Clearly documented all new API functions with PEP257 and numpydoc compliant docstrings.
  • Added new API functions to docs/api.rst.
  • Non-API functions clearly documented with docstrings or comments as necessary.
  • Adds description and name entries in the appropriate "what's new" file
    in docs/whatsnew
    for all changes. Includes link to the GitHub Issue with :issue:`num`
    or this Pull Request with :pull:`num`. Includes contributor name
    and/or GitHub username (link with :ghuser:`user`).
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels and Milestone are assigned to the Pull Request and linked Issue.

Add the minimum GHI limit test from (10.1016/j.renene.2022.11.056) Quality control procedure for 1-minute pyranometric measurements of global and shadowband-based diffuse solar irradiance by F. Nollas, G. Salazar, & C. Gueymard.

See #172 for further details.

@AdamRJensen AdamRJensen marked this pull request as draft November 30, 2022 14:09
@AdamRJensen AdamRJensen changed the title Add minimum Nollas GHI min limit Add minimum GHI min limit (Nollas, 2023) Nov 30, 2022
@AdamRJensen AdamRJensen changed the title Add minimum GHI min limit (Nollas, 2023) Add minimum GHI limit (Nollas, 2023) Nov 30, 2022
@AdamRJensen
Copy link
Member Author

To make this PR pleasant to review, I'll make follow up PR adding checking of DHI which is somewhat more complex.

@AdamRJensen AdamRJensen marked this pull request as ready for review June 1, 2023 18:14
@AdamRJensen AdamRJensen changed the title Add minimum GHI limit (Nollas, 2023) Add minimum GHI limit from Nollas et al. (2023) Jun 1, 2023
@AdamRJensen AdamRJensen changed the title Add minimum GHI limit from Nollas et al. (2023) Add minimum GHI limit check from Nollas et al. (2023) Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minimum GHI limit (QC check)
1 participant