Adding In Ability To Search By Date Retrieved #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filtering on created_utc makes accurately capturing deltas more difficult, as you can't necessarily lock down time windows in the past, as there's no guarantees data won't be added in the future. In this pull request, I have implemented the ability to add 'retrieved_before' and 'retrieved_after' to the query string, which will work the 'retrieved_on' field the same way that 'before' and 'after' work on the created_utc field.
I have also removed a couple of semicolons from the code that ought not to be there, and ran the code through a linter.