Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve ReactNativeScannerView Start Sequence #22

Merged
merged 1 commit into from
May 18, 2024

Conversation

pushpender-singh-ap
Copy link
Owner

This change introduces a dispatch queue for starting the AVCaptureSession (_session) asynchronously in the ReactNativeScannerView component. By moving the _session.startRunning call to a serial dispatch queue named "session queue", the UI thread is no longer blocked by the session start process, potentially improving the UI responsiveness and performance of the application.

@pushpender-singh-ap pushpender-singh-ap added the enhancement New feature or request label May 18, 2024
@pushpender-singh-ap pushpender-singh-ap self-assigned this May 18, 2024
@pushpender-singh-ap pushpender-singh-ap linked an issue May 18, 2024 that may be closed by this pull request
@pushpender-singh-ap pushpender-singh-ap changed the title Improve ReactNativeScannerView Start Sequence fix: Improve ReactNativeScannerView Start Sequence May 18, 2024
@pushpender-singh-ap pushpender-singh-ap merged commit 2f5ec51 into main May 18, 2024
1 check passed
@pushpender-singh-ap pushpender-singh-ap deleted the bug/21 branch May 18, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

-[AVCaptureSession startRunning] working on the main thread
1 participant