Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding purescript-language-server to tools #346

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Adding purescript-language-server to tools #346

wants to merge 1 commit into from

Conversation

andys8
Copy link
Contributor

@andys8 andys8 commented Aug 20, 2020

Minor change: purescript-language-server also supports suggestions

thomashoneyman
thomashoneyman requested changes Aug 20, 2020
View reviewed changes
Copy link
Member

@thomashoneyman thomashoneyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor typo, but 👍

guides/Error-Suggestions.md Outdated Show resolved Hide resolved
@thomashoneyman
Copy link
Member

I'm not able to merge this, but 👍

@thomashoneyman
Copy link
Member

On second thought -- #347 updates the editor and tooling support section in the documentation and includes the language server. Does it make sense for there to be two documentation sections? Isn't this content already covered there?

I might be more in support of removing this documentation altogether.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomashoneyman thomashoneyman thomashoneyman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andys8 @thomashoneyman