-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VOSS upgrade PROS kernel to 4.0.7 #98
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
There were too many comments to post at once. Showing the first 25 out of 263. Check the log or trigger a new build to see more.
@@ -41,8 +41,8 @@ | |||
|
|||
#define PROS_VERSION_MAJOR 4 | |||
#define PROS_VERSION_MINOR 0 | |||
#define PROS_VERSION_PATCH 5 | |||
#define PROS_VERSION_STRING "4.0.5" | |||
#define PROS_VERSION_PATCH 7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: macro 'PROS_VERSION_PATCH' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage]
#define PROS_VERSION_PATCH 7
^
#define PROS_VERSION_PATCH 5 | ||
#define PROS_VERSION_STRING "4.0.5" | ||
#define PROS_VERSION_PATCH 7 | ||
#define PROS_VERSION_STRING "4.0.7" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: macro 'PROS_VERSION_STRING' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage]
#define PROS_VERSION_STRING "4.0.7"
^
@@ -14,13 +14,13 @@ extern "C" { | |||
* INCLUDES | |||
*********************/ | |||
|
|||
#include "../../lv_conf_internal.h" | |||
#include "liblvgl/lv_conf_internal.h" | |||
|
|||
#include LV_GPU_SDL_INCLUDE_PATH |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: expected "FILENAME" or [clang-diagnostic-error]
#include LV_GPU_SDL_INCLUDE_PATH
^
@@ -14,13 +14,13 @@ extern "C" { | |||
* INCLUDES | |||
*********************/ | |||
|
|||
#include "../../lv_conf_internal.h" | |||
#include "liblvgl/lv_conf_internal.h" | |||
|
|||
#include LV_GPU_SDL_INCLUDE_PATH |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: expected "FILENAME" or [clang-diagnostic-error]
#include LV_GPU_SDL_INCLUDE_PATH
^
@@ -28,7 +28,7 @@ freely, subject to the following restrictions: | |||
|
|||
#include <string.h> /*for size_t*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: 'string.h' file not found [clang-diagnostic-error]
#include <string.h> /*for size_t*/
^
automatically into RAM)*/ | ||
|
||
/* Enable anti-aliasing (lines, and radiuses will be smoothed) */ | ||
#define LV_ANTIALIAS 1 /*1: Enable anti-aliasing*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: macro 'LV_ANTIALIAS' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage]
#define LV_ANTIALIAS 1 /*1: Enable anti-aliasing*/
^
#define LV_ANTIALIAS 1 /*1: Enable anti-aliasing*/ | ||
|
||
/*Screen refresh settings*/ | ||
#define LV_REFR_PERIOD 40 /*Screen refresh period in milliseconds*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: macro 'LV_REFR_PERIOD' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage]
#define LV_REFR_PERIOD 40 /*Screen refresh period in milliseconds*/
^
|
||
/*Screen refresh settings*/ | ||
#define LV_REFR_PERIOD 40 /*Screen refresh period in milliseconds*/ | ||
#define LV_INV_FIFO_SIZE 32 /*The average count of objects on a screen */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: macro 'LV_INV_FIFO_SIZE' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage]
#define LV_INV_FIFO_SIZE 32 /*The average count of objects on a screen */
^
*=================*/ | ||
|
||
/*Input device settings*/ | ||
#define LV_INDEV_READ_PERIOD 50 /*Input device read period in milliseconds*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: macro 'LV_INDEV_READ_PERIOD' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage]
#define LV_INDEV_READ_PERIOD 50 /*Input device read period in milliseconds*/
^
|
||
/*Input device settings*/ | ||
#define LV_INDEV_READ_PERIOD 50 /*Input device read period in milliseconds*/ | ||
#define LV_INDEV_POINT_MARKER \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: macro 'LV_INDEV_POINT_MARKER' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage]
#define LV_INDEV_POINT_MARKER \
^
No description provided.