Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VOSS upgrade PROS kernel to 4.0.7 #98

Merged
merged 1 commit into from
May 15, 2024
Merged

VOSS upgrade PROS kernel to 4.0.7 #98

merged 1 commit into from
May 15, 2024

Conversation

Rocky14683
Copy link
Member

No description provided.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 25 out of 263. Check the log or trigger a new build to see more.

@@ -41,8 +41,8 @@

#define PROS_VERSION_MAJOR 4
#define PROS_VERSION_MINOR 0
#define PROS_VERSION_PATCH 5
#define PROS_VERSION_STRING "4.0.5"
#define PROS_VERSION_PATCH 7
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: macro 'PROS_VERSION_PATCH' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage]

#define PROS_VERSION_PATCH 7
        ^

#define PROS_VERSION_PATCH 5
#define PROS_VERSION_STRING "4.0.5"
#define PROS_VERSION_PATCH 7
#define PROS_VERSION_STRING "4.0.7"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: macro 'PROS_VERSION_STRING' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage]

#define PROS_VERSION_STRING "4.0.7"
        ^

@@ -14,13 +14,13 @@ extern "C" {
* INCLUDES
*********************/

#include "../../lv_conf_internal.h"
#include "liblvgl/lv_conf_internal.h"

#include LV_GPU_SDL_INCLUDE_PATH
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: expected "FILENAME" or [clang-diagnostic-error]

#include LV_GPU_SDL_INCLUDE_PATH
         ^

@@ -14,13 +14,13 @@ extern "C" {
* INCLUDES
*********************/

#include "../../lv_conf_internal.h"
#include "liblvgl/lv_conf_internal.h"

#include LV_GPU_SDL_INCLUDE_PATH
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: expected "FILENAME" or [clang-diagnostic-error]

#include LV_GPU_SDL_INCLUDE_PATH
         ^

@@ -28,7 +28,7 @@ freely, subject to the following restrictions:

#include <string.h> /*for size_t*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'string.h' file not found [clang-diagnostic-error]

#include <string.h> /*for size_t*/
         ^

automatically into RAM)*/

/* Enable anti-aliasing (lines, and radiuses will be smoothed) */
#define LV_ANTIALIAS 1 /*1: Enable anti-aliasing*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: macro 'LV_ANTIALIAS' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage]

#define LV_ANTIALIAS 1 /*1: Enable anti-aliasing*/
        ^

#define LV_ANTIALIAS 1 /*1: Enable anti-aliasing*/

/*Screen refresh settings*/
#define LV_REFR_PERIOD 40 /*Screen refresh period in milliseconds*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: macro 'LV_REFR_PERIOD' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage]

#define LV_REFR_PERIOD 40   /*Screen refresh period in milliseconds*/
        ^


/*Screen refresh settings*/
#define LV_REFR_PERIOD 40 /*Screen refresh period in milliseconds*/
#define LV_INV_FIFO_SIZE 32 /*The average count of objects on a screen */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: macro 'LV_INV_FIFO_SIZE' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage]

#define LV_INV_FIFO_SIZE 32 /*The average count of objects on a screen */
        ^

*=================*/

/*Input device settings*/
#define LV_INDEV_READ_PERIOD 50 /*Input device read period in milliseconds*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: macro 'LV_INDEV_READ_PERIOD' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage]

#define LV_INDEV_READ_PERIOD 50 /*Input device read period in milliseconds*/
        ^


/*Input device settings*/
#define LV_INDEV_READ_PERIOD 50 /*Input device read period in milliseconds*/
#define LV_INDEV_POINT_MARKER \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: macro 'LV_INDEV_POINT_MARKER' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage]

#define LV_INDEV_POINT_MARKER                                                  \
        ^

@Rocky14683 Rocky14683 merged commit cb55a39 into master May 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants