Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commuters as objects #28

Merged
merged 28 commits into from
Apr 25, 2019
Merged

Commuters as objects #28

merged 28 commits into from
Apr 25, 2019

Conversation

aaron97neu
Copy link
Member

This branch converted commuters from the 4D array of strings to a proper python class. All tests pass (Which is better than the current dev branch).

Test suite has been updated for an additional test that verifies that two commuters can exist and move while in two different zip codes, which was not possible before

This fixes issue #9 and will help with #7 and #8

aaron97neu and others added 27 commits October 30, 2018 18:42
@aaron97neu aaron97neu added the enhancement New feature or request label Apr 24, 2019
@aaron97neu aaron97neu self-assigned this Apr 24, 2019
Copy link
Contributor

@HarshPatel682 HarshPatel682 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests work on my end and code looks good.

@aaron97neu aaron97neu merged commit 63b7801 into dev Apr 25, 2019
@aaron97neu aaron97neu deleted the commutersAsObjects branch April 25, 2019 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants