Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase pfind dialog box size to show correctly #3953

Open
wants to merge 1 commit into
base: testing
Choose a base branch
from

Conversation

Overdrive5
Copy link

Increase pfind dialog box size to show correctly. 450x700 is to small. 750x950 shows the entire app without having to resize every time.

Increase pfind dialog box size to show correctly. 450x700 is to small. 750x950 shows the entire app without having to resize every time.
@Overdrive5
Copy link
Author

450x700:
pfind450x700
750x950:
pfind750x950

@zigbert
Copy link
Contributor

zigbert commented Feb 28, 2023

It should not that big by default in case Puppy is running on small screen.

If size should be enlarged, it should be only on screens that are big enough.
xrandr could give information for X. But these days Puppy is also running on Wayland... ?

xrandr | grep '*' | head -n1

The existing solution for this issue is found in the 'File' menu. - Quit and save geometry.

@Overdrive5
Copy link
Author

Oh!! I see!. Never observed that before.

Always just used the standard mouse 'x' close method.

@dimkr
Copy link
Contributor

dimkr commented Mar 1, 2023

But these days Puppy is also running on Wayland... ?

Yes, xrandr won't work.

@Overdrive5
Copy link
Author

Maybe use?: xdpyinfo | grep dimensions

@Overdrive5
Copy link
Author

Overdrive5 commented Mar 3, 2023

I find my scrollbars disappear at 679 x 936

Maybe do a xdpyinfo test if it exceeds these dimensions then set accordingly?

@Overdrive5
Copy link
Author

xdpyinfo | grep -oP 'dimensions:\s+\K\S+'

@zigbert
Copy link
Contributor

zigbert commented Mar 5, 2023

I am unfamiliar with 'xdpyinfo', and don't know if this would work outside X.

It would still an option to include a test for both xrandr and xdpyinfo. If it doesn't give any valuable feedback, we just go back to the default values.

This test must not override the default settings in $HOME/.pfind/pfindrc. The rc file could have blank values at first startup and the test could save its new value for later use.

@Overdrive5
Copy link
Author

I found the method of getting each dimension separately.

Width: xdpyinfo | awk '/dimensions/ {print $2}' | cut -d 'x' -f1
Height: xdpyinfo | awk '/dimensions/ {print $2}' | cut -d 'x' -f2

@Overdrive5
Copy link
Author

So we could confirm both width exceed 936 and height exceed 679 then set pfindrc to those dimensions.

@Overdrive5
Copy link
Author

And I checked pup-431.iso and xdpyinfo is located in /usr/bin so it should be available for most recent distributions

@dimkr
Copy link
Contributor

dimkr commented Mar 11, 2023

xdpyinfo won't work in a Puppy that uses Wayland. Make sure you have some fallback if xdpyinfo fails (or if it's missing).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants