Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "(maint) Exclude breaking rubocop versions" #385

Merged
merged 3 commits into from
Jun 20, 2024

Conversation

gavindidrichsen
Copy link
Contributor

Reverts #380

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 15.38462% with 22 lines in your changes missing coverage. Please review.

Project coverage is 11.69%. Comparing base (ac89014) to head (b65b51c).

Files Patch % Lines
lib/puppet-languageserver/sidecar_protocol.rb 0.00% 6 Missing ⚠️
lib/puppet-debugserver/puppet_debug_session.rb 0.00% 3 Missing ⚠️
...uppet-languageserver/session_state/object_cache.rb 0.00% 3 Missing ⚠️
...ppet_editor_services/protocol/json_rpc_messages.rb 0.00% 3 Missing ⚠️
lib/puppet_editor_services/server/tcp.rb 0.00% 2 Missing ⚠️
.../puppet-debugserver/debug_session/hook_handlers.rb 0.00% 1 Missing ⚠️
...ppet-languageserver/global_queues/sidecar_queue.rb 0.00% 1 Missing ⚠️
...t-languageserver/global_queues/validation_queue.rb 0.00% 1 Missing ⚠️
lib/puppet-languageserver/message_handler.rb 0.00% 1 Missing ⚠️
lib/puppet_editor_services/protocol/json_rpc.rb 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #385   +/-   ##
=======================================
  Coverage   11.69%   11.69%           
=======================================
  Files          92       92           
  Lines       11504    11501    -3     
=======================================
  Hits         1345     1345           
+ Misses      10159    10156    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gavindidrichsen gavindidrichsen marked this pull request as ready for review June 20, 2024 11:51
@gavindidrichsen gavindidrichsen requested a review from a team as a code owner June 20, 2024 11:51
Signed-off-by: Gavin Didrichsen <[email protected]>
@gavindidrichsen gavindidrichsen force-pushed the revert-380-maint_exclude_rubocop_versions branch from 6ff69ff to b65b51c Compare June 20, 2024 13:06
@david22swan david22swan merged commit 497f214 into main Jun 20, 2024
14 checks passed
@david22swan david22swan deleted the revert-380-maint_exclude_rubocop_versions branch June 20, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants