Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(CAT-2122) Re-initialize windows-2019/ruby-3.2 nightly test run #1417

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

david22swan
Copy link
Member

@david22swan david22swan commented Nov 11, 2024

With the recent removal of JSON::Pure from the code, the dependency error that had been causing failures on this specific box, and not on local vagrant/docker/vmpooler runs with the same windows-2019/ruby-3.2 setup, have been resolved.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified.

With the recent removal of `JSON::Pure` from the code, the dependency error that had been causing failures on this specific box, and not on local vagrant/docker/vmpooler runs with the same  windows-2019/ruby-3.2 setup has been resolved.
@david22swan david22swan added the maintenance Internal maintenance work that shouldn't appear in the changelog label Nov 11, 2024
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.48%. Comparing base (f0f8786) to head (72e5efa).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1417   +/-   ##
=======================================
  Coverage   88.48%   88.48%           
=======================================
  Files         127      127           
  Lines        5317     5317           
=======================================
  Hits         4705     4705           
  Misses        612      612           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@david22swan david22swan marked this pull request as ready for review November 11, 2024 15:35
@david22swan david22swan requested a review from a team as a code owner November 11, 2024 15:35
Copy link
Contributor

@LukasAud LukasAud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LukasAud LukasAud merged commit c62056e into main Nov 11, 2024
12 checks passed
@LukasAud LukasAud deleted the CAT-2122 branch November 11, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Internal maintenance work that shouldn't appear in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants