Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(GH-2550) Do not ship with PuppetBolt PowerShell module #164

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

beechtom
Copy link
Contributor

This updates the Windows MSI build to not install the PuppetBolt
PowerShell module. Users should now install the PuppetBolt PowerShell
module through the PowerShell Gallery.

This updates the Windows MSI build to not install the PuppetBolt
PowerShell module. Users should now install the PuppetBolt PowerShell
module through the PowerShell Gallery.
@beechtom
Copy link
Contributor Author

Built the MSI and installed on a Windows 10 Ent VM. Confirmed that the MSI does not install the PowerShell module.

@beechtom beechtom self-assigned this May 13, 2021
@beechtom
Copy link
Contributor Author

Also confirmed that upgrading Bolt successfully removes the PuppetBolt module installed with older MSIs.

Copy link
Contributor

@jpogran jpogran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, code works and is tested in all the ways I can think of

@lucywyman
Copy link
Contributor

Note: Since this is a breaking change and we've pretty well missed the boat on Bolt 3.0, we're going to add a deprecation warning to the MSI when the module is imported telling users to install the module themselves from PowerShell Gallery, and add documentation telling users to do so as well. We'll wait until Bolt 4.0 to merge this.

@CLAassistant
Copy link

CLAassistant commented Sep 1, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants