Remove unused StorageMeta, improve efficiency of SupportedSchemes() b…

…y using a RLock() not a RW lock.
puppetlabs-toy-chest · Aug 1, 2019 · 3af186f · 3af186f
1 parent fb75d51
commit 3af186f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 8 deletions.
diff --git a/storage/api.go b/storage/api.go
@@ -44,12 +44,6 @@ func NewStorageError(code StorageErrorCode, msg string, cause error) *StorageErr
 	}
 }
 
-type StorageMeta struct {
-	Key           string
-	Metadata      map[string]string
-	ContentLength int64
-}
-
 type StorageSink func(io.Writer) error
 type StorageSrc func(io.Reader) error
 

diff --git a/storage/factory.go b/storage/factory.go
@@ -39,8 +39,8 @@ func RegisterFactory(scheme string, factory BlobStorageFactory) {
 }
 
 func SupportedSchemes() []string {
-	factoriesMu.Lock()
-	defer factoriesMu.Unlock()
+	factoriesMu.RLock()
+	defer factoriesMu.RUnlock()
 	var list []string
 	for scheme := range factories {
 		list = append(list, scheme)