Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

truncate superfluous leading dim from calibration data #20

Merged
merged 2 commits into from
Aug 19, 2024
Merged

truncate superfluous leading dim from calibration data #20

merged 2 commits into from
Aug 19, 2024

Conversation

domstoppable
Copy link
Member

No description provided.

@domstoppable domstoppable requested a review from dourvaris August 8, 2024 17:09
@domstoppable domstoppable mentioned this pull request Aug 8, 2024
Merged
@domstoppable
Copy link
Member Author

@dourvaris this implements your suggestion (minus the __post_init__ function to decode the serial byte array - this is only possible in dataclasses, not namedtuples)

@dourvaris dourvaris merged commit f51201a into main Aug 19, 2024
14 checks passed
@dourvaris dourvaris deleted the calibration_trunc branch August 19, 2024 09:28
marc-tonsen pushed a commit that referenced this pull request Nov 19, 2024
@dourvaris
Merge pull request #20 from pupil-labs/calibration_trunc
235ba60 
truncate superfluous leading dim from calibration data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dourvaris dourvaris Awaiting requested review from dourvaris

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@domstoppable @dourvaris