we can now build & run on arm64 mac natively

[rennis250]

No description provided.

[domstoppable]

I'm leaning towards this not being merged - at least not in this way - for a couple of reasons

1. The x86 build works for all Intel-Macs and ARM-Macs (with Rosetta). If we distribute an official ARM build, we will still need an x86 build for those users, and I think requiring Rosetta for ARM users is less complex than making them choose the correct download
2. Downgrading ffmpeg risks performance, stability, etc.

Perhaps rather than modifying the official build we can provide instructions somewhere (I'd suggest the wiki, which is currently empty). IMO, it's fine if a user wants to take the risks from point 2 above, but I don't want to in an official build without at least knowing what we might be losing by downgrading. I'm not sure the effort is even worthwhile given point 1 above.

[rennis250]

Alright! I agree. I close this.

[rennis250]

But does this not imply that the Intel binaries/wheels are using ffmpeg 5, since the error is that the code in pyndsi is not compatible with ffmpeg 6?

[domstoppable]

Could be - I don't know, TBH. I didn't really look because of point 1 above.

Thinking about this some more, I'm actually ok with a note about how to make an ARM build in the readme, although I still don't want to provide a separate ARM build unless there's significant benefit. I imagine (although, admittedly, I really don't know) that most of our users will already have Rosetta installed whether they are aware or not, and a single build for all mac users is ideal.

[rennis250]

Took a look. Pyndsi is currently fetching ffmpeg 5.1.2:

https://github.com/pupil-labs/pyndsi/blob/master/scripts/fetch-ffmpeg.json

Agreed on not providing too many builds.
I'm also fine with just some notes in the README.

[domstoppable]

@rennis250 do these new MacOS instructions work for Intel mac as well as ARM, or are they ARM-specific? Either way, we should clarify

[rennis250]

@domstoppable Ah ha! Sorry. Right, it is intended for ARM. I thought I put that in the text.
It might work for Intel, but have not tested.