Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick click leaves drag template ghost that won't disappear #503

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

robbiehinch
Copy link

Added mouse button down guard around DragEnter

Please check the logging (now removed) added in commit 80d9ac5

Doing a fast click, drag, release can make the drag template stay open indefinitely. It's because the DragEnter event handler can be called after the DragSourceOnQueryContinueDrag event, but there are no mouse buttons depressed when it is called:

DragSourceOnMouseMove Left Pressed
_draginProgress true
DoDragSourceMove setting preview
UpdatePreviewPresenter ->
setting template
DragSourceOnQueryContinueDrag setting nulls
DropTargetOnDragEnter Copy, Move None
DragEnter
DropTargetOnDragOver setting preview
UpdatePreviewPresenter ->
setting template
UpdatePreviewPresenter ->
visual source not null
Drag cancelled
DragDropOperationFinished None
_draginProgress false
DragLeave

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants