Protect declaredRuntimeMetadata with a sync.Mutex
#2733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should fix the immediate issue. We should probably refactor this to avoid the global, but that can be done later. Fixes #2728
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2733 +/- ##
==========================================
- Coverage 69.57% 69.57% -0.01%
==========================================
Files 301 301
Lines 38654 38658 +4
==========================================
+ Hits 26893 26895 +2
- Misses 10242 10245 +3
+ Partials 1519 1518 -1 ☔ View full report in Codecov by Sentry. |
|
Excellent ty. |
t0yv0
approved these changes
Dec 12, 2024
|
|
This PR has been shipped in release v3.98.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the immediate issue. We should probably refactor this to avoid the global, but that can be done later.
Fixes #2728