-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove top-level pf folder #2653
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2653 +/- ##
=======================================
Coverage 69.97% 69.97%
=======================================
Files 367 367
Lines 44504 44504
=======================================
+ Hits 31141 31142 +1
- Misses 11734 11735 +1
+ Partials 1629 1627 -2 ☔ View full report in Codecov by Sentry. |
There are still a couple things to do before it's "safe" to remove this:
Step (2) means technically we might want to keep this around forever to avoid breaking third-parties years from now. |
Summary of internal discussion:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to wait at least one more release, then verify that this won't break people before merging.
I have created #2685 to track the work here. |
#2690 did this. |
We have migrated the PF functionality to live inside of
pkg/pf
instead of its own module.This pull request removes the deprecated files.
Reference:
#2480
pulumi/ci-mgmt#1103