Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Reference Google Cloud Resources Across Stacks Tutorial Content #13347

Merged
merged 15 commits into from
Dec 3, 2024
Merged

Add Reference Google Cloud Resources Across Stacks Tutorial Content #13347

merged 15 commits into from
Dec 3, 2024

Conversation

toriancrane
Copy link
Contributor

Proposed changes

  • Adds the content for the Google Cloud-specific stack references and outputs tutorials
  • Updates the closing paragraph of the Azure stack ref tutorial to replace incorrect AWS references with Azure references.

@toriancrane toriancrane requested a review from a team as a code owner November 14, 2024 13:46
@pulumi-bot
Copy link
Collaborator

Your site preview for commit e74efdc is ready! 🎉

http://www-testing-pulumi-docs-origin-pr-13347-e74efdc1.s3-website.us-west-2.amazonaws.com.

@pulumi-bot
Copy link
Collaborator

Your site preview for commit 3d25433 is ready! 🎉

http://www-testing-pulumi-docs-origin-pr-13347-3d254339.s3-website.us-west-2.amazonaws.com.

@pulumi-bot
Copy link
Collaborator

Your site preview for commit 3c40849 is ready! 🎉

http://www-testing-pulumi-docs-origin-pr-13347-3c40849b.s3-website.us-west-2.amazonaws.com.

dirien
dirien approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@dirien dirien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! But I did not run all the code to see if it's working on runtime.

thoward
thoward requested changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@thoward thoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (except the asset bundles as noted)

assets/css/bundle.css Outdated Show resolved Hide resolved
content/tutorials/stack-outputs-refs-azure/index.md Show resolved Hide resolved
@toriancrane toriancrane enabled auto-merge (squash) December 3, 2024 10:46
@pulumi-bot
Copy link
Collaborator

Your site preview for commit 35d76ef is ready! 🎉

http://www-testing-pulumi-docs-origin-pr-13347-35d76ef0.s3-website.us-west-2.amazonaws.com.

@toriancrane toriancrane merged commit 180a84d into master Dec 3, 2024
8 checks passed
@toriancrane toriancrane deleted the torian/stackref-gcp branch December 3, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirien dirien dirien approved these changes

@thoward thoward thoward approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@toriancrane @pulumi-bot @thoward @dirien