Process S3 redirects in parallel #10019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnunciato
force-pushed
the
cnunciato/s3-redirs
branch
from
35f0dda to
46e0449
Compare
cnunciato
force-pushed
the
cnunciato/s3-redirs
branch
from
46e0449 to
56442e8
Compare
cnunciato
force-pushed
the
cnunciato/s3-redirs
branch
from
56442e8 to
589a100
Compare
cnunciato
force-pushed
the
cnunciato/s3-redirs
branch
from
589a100 to
c04cf63
Compare
|
LGTM. nice that it only took two seconds. It took around 1 minute using bash when I did it locally with that I was doing before. yay node!! 🚀 |
sean1588
approved these changes
Oct 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the
make-s3-redirects.shscript to process S3 301 redirects in parallel with Node.js.Takes about 2 seconds to run this locally, so should shave 20-30 minutes off the tail end of the
pushjob. 🎉Run
./scripts/on-demand-build-sync-test.shto see it run in the context of a build.