fix: modify types and add GH workflow test

pulumi · Dec 28, 2022 · 00c493b · 00c493b
1 parent 68442af
commit 00c493b
Show file tree

Hide file tree

Showing 4 changed files with 28 additions and 8 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -12,6 +12,11 @@ on: # rebuild any PRs and main branch changes
       - 'CHANGELOG.md'
       - 'README.md'
 
+env:
+  TEST_PLUGIN_NAME: "time"
+  TEST_PLUGIN_VERSION: "0.0.9"
+  TEST_PLUGIN_SERVER: "https://github.com/pulumiverse/pulumi-time/releases/download/v0.0.9"
+
 jobs:
   build-test: # make sure build/ci work properly
     runs-on: ubuntu-latest
@@ -55,5 +60,8 @@ jobs:
           upsert: true
           work-dir: .github/test-stacks/golang
           config-map: "{name: {value: test, secret: false}}"
-          plugins: "[{name: time, version: 0.0.9, kind: resource}]"
+          plugins: "[{name: ${{ env.TEST_PLUGIN_NAME }}, version: ${{ env.TEST_PLUGIN_VERSION }}, server: ${{ env.TEST_PLUGIN_SERVER }}}]"
       - run: echo 'The random string is `${{ steps.pulumi.outputs.name }}`'
+      - run: |
+          pulumi plugin ls | grep ${{ env.TEST_PLUGIN_NAME }} | grep ${{ env.TEST_PLUGIN_VERSION }}
+          exit $?
diff --git a/src/__tests__/config.test.ts b/src/__tests__/config.test.ts
@@ -53,9 +53,9 @@ describe('config.ts', () => {
           "targetDependents": undefined,
           "userAgent": "pulumi/actions@v3",
         },
+        "plugins": Array [],
         "refresh": undefined,
         "remove": undefined,
-        "plugins": undefined,
         "secretsProvider": undefined,
         "stackName": "dev",
         "upsert": undefined,
@@ -119,9 +119,9 @@ describe('config.ts', () => {
           "targetDependents": undefined,
           "userAgent": "pulumi/actions@v3",
         },
+        "plugins": Array [],
         "refresh": undefined,
         "remove": undefined,
-        "plugins": undefined,
         "secretsProvider": undefined,
         "stackName": "dev",
         "upsert": undefined,
@@ -177,9 +177,9 @@ describe('config.ts', () => {
           "targetDependents": undefined,
           "userAgent": "pulumi/actions@v3",
         },
+        "plugins": Array [],
         "refresh": undefined,
         "remove": undefined,
-        "plugins": undefined,
         "secretsProvider": undefined,
         "stackName": "dev",
         "upsert": undefined,

diff --git a/src/config.ts b/src/config.ts
@@ -1,7 +1,7 @@
 import { getInput } from '@actions/core';
 import { context } from '@actions/github';
 import * as rt from 'runtypes';
-import { parseArray, parseBoolean, parseNumber } from './libs/utils';
+import { parseArray, parseBoolean, parseNumber, parsePlugins } from './libs/utils';
 
 export const command = rt.Union(
   rt.Literal('up'),
@@ -18,8 +18,8 @@ const plugin = rt.Partial({
   server: rt.String,
   kind: rt.String
 });
-type Plugin = rt.Static<typeof plugin>;
-type Plugins = Plugin[];
+export type Plugin = rt.Static<typeof plugin>;
+export type Plugins = Plugin[];
 
 export const options = rt.Partial({
   parallel: rt.Number,
@@ -78,7 +78,7 @@ export async function makeConfig(): Promise<Config> {
     remove: parseBoolean(getInput('remove')),
     refresh: parseBoolean(getInput('refresh')),
     configMap: getInput('config-map'),
-    plugins: JSON.parse(getInput('plugins')) as Plugins,
+    plugins: parsePlugins(getInput('plugins')),
     isPullRequest: context?.payload?.pull_request !== undefined,
     options: {
       parallel: parseNumber(getInput('parallel')),

diff --git a/src/libs/utils.ts b/src/libs/utils.ts
@@ -1,3 +1,6 @@
+import YAML from 'yaml';
+import { Plugin, Plugins } from '../config';
+
 export function parseArray(input: string): string[] {
   return parseUndefined(input)
     ? input.split(/\r?\n/).reduce<string[]>(
@@ -22,3 +25,12 @@ export function parseBoolean(input: string): boolean | undefined {
 export function parseNumber(input: string): number | undefined {
   return parseUndefined(input) ? Number(input) : undefined;
 }
+
+export function parsePlugins(input: string): Plugins {
+  if (parseUndefined(input)) {
+    const plugins = YAML.parse(input);
+    return plugins.map(plugin => plugin as Plugin) as Plugins;
+  } else {
+    return [] as Plugins;
+  }
+}