electron-builder: Don't create differential update blockmaps #1139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are *extremely* computationally intensive to make, and we don't even use them. Use these undocumented config options to skip making them entirely. Source (where I learned about these config options): github[dot]com/electron-userland/electron-builder/issues/2900#issuecomment-730571696 By the way, the impetus for disabling these is that macOS 13 CI keeps failing at the blockmap creation step. We want successful binary builds in CI! Note: There apparently is no way to disable blockmaps for the .zip target on macOS. Only for the macOS .dmg and the Windows NSIS targets.
DeeDeeG
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are extremely computationally intensive to make, and we don't even use them. Use these undocumented config options to skip making them entirely.
Source (where I learned about these config options): github[dot]com/electron-userland/electron-builder/issues/2900#issuecomment-730571696
By the way, the impetus for disabling these is that macOS 13 CI keeps failing at the blockmap creation step. We want successful binary builds in CI!
Note: There apparently is no way to disable blockmaps for the .zip target on macOS. Only for the macOS .dmg and the Windows NSIS targets.