Added reference to plugin settings config docs #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lubosmj
reviewed
Mar 13, 2024
pulp-in-one-container.md
Outdated
| @@ -23,9 +23,15 @@ $ mkdir settings pulp_storage pgsql containers | |||
| $ echo "CONTENT_ORIGIN='http://$(hostname):8080' | |||
| ANSIBLE_API_HOSTNAME='http://$(hostname):8080' | |||
| ANSIBLE_CONTENT_HOSTNAME='http://$(hostname):8080/pulp/content' | |||
| TOKEN_SERVER = "http://(hostname):24817/token/" | |||
There was a problem hiding this comment.
The port is 8080 in this case. Also, I am not sure this will work since the user would need to run the openssl utility to create the keys.
lubosmj
reviewed
Mar 13, 2024
pulp-in-one-container.md
Outdated
| CACHE_ENABLED=True" >> settings/settings.py | ||
| ``` | ||
|
|
||
| Refer to plugin settings configuration docs for more. |
There was a problem hiding this comment.
Perhaps, we can be more specific here and reference the pulp_container documentation. I do not know if there are any other plugins that require the customization to the settings file before booting up the container.
There was a problem hiding this comment.
That's why it is better to stay generic because you don't know, plus things can change in future and you will need to otherwise keep track of each plugin settings.
lubosmj
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[noissue]