Skip to content

Commit

Permalink
Fixed incorrect error when using custom signing service
Browse files Browse the repository at this point in the history
Previously, a `SyntaxError` was being thrown because the artifact list
incorrectly called the `delete` method instead of the correct `remove`
method to remove a Release. The `delete` method does not exist for
lists, leading to the error.

closes #1122
  • Loading branch information
hstct committed Jul 30, 2024
1 parent 7e29ff1 commit f5317e0
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGES/1122.bugfix
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fixed throwing the wrong error when pointing to an invalid repository with a custom signing service.
2 changes: 1 addition & 1 deletion pulp_deb/app/tasks/synchronizing.py
Original file line number Diff line number Diff line change
Expand Up @@ -399,7 +399,7 @@ async def run(self):
release_file.relative_path = da_names["Release"].relative_path
else:
if self.gpgkey:
d_content.d_artifacts.delete(da_names["Release"])
d_content.d_artifacts.remove(da_names["Release"])
else:
release_file_artifact = da_names["Release"].artifact
release_file.relative_path = da_names["Release"].relative_path
Expand Down

0 comments on commit f5317e0

Please sign in to comment.