poc - cookie auth #124
Draft
poc - cookie auth #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
himdel
force-pushed
the
tmp
branch
2 times, most recently
from
9822859
to
941a273
Compare
use /auth/login/ for cookies remove last AppContext.user, switch to UserContext.getUsername/isLoggedIn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rough draft, this will need a couple more steps to get there right, but:
UI_EXTERNAL_LOGIN_URIto/auth/login/open http://localhost:8002/auth/login/?next=%2Fui%2Flogin%2F
20241024173944.mp4
(the rest of the PR is dealing with appContext.user logic, disabling fetch withCredentials:false which is needed for basic auth to work, and TODO loading user info)