Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rss-listing and link in help page #93

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

pedro-psb
Copy link
Member

This adds @himdel rss feed link into pulp website and a simple listing of it's content.

Its added to the end of the help page (after quicklinks).

image

@pedro-psb pedro-psb requested a review from himdel October 23, 2024 15:46
@pedro-psb
Copy link
Member Author

I tried creating an html page /rss/index.html with <link rel="alternate" type="application/rss+xml" title="Changes RSS Feed" href="https://himdel.eu/feed/pulp-changes.json" /> in the head tag, but the rss client I tried wasnt able to fetch from that link (only directly from your server).

But I guess it's okay to keep your server link, if you don't mind.
Later I can create a similar script in python to generate the rss-json on build time (it's built/published nightly).

@pedro-psb pedro-psb merged commit 1a6b687 into pulp:main Oct 29, 2024
4 checks passed
@pedro-psb pedro-psb deleted the add/rss-feed-widget branch October 29, 2024 19:52
@himdel
Copy link

himdel commented Oct 30, 2024

👍

Yeah, most rss readers expect to get urls directly to the feed, the <link is just so that browsers/extensions can tell you about the feed being there and send it to the reader.

I'm fine with using my server, it's just serving a static file, and reparsing the changlogs daily :)

Thanks for adding this :)

@pedro-psb
Copy link
Member Author

Yeah, most rss readers expect to get urls directly to the feed, the <link is just so that browsers/extensions can tell you about the feed being there and send it to the reader.

Oh, I didnt know exactly how that worked. So it is supposed to be on all pages' headers, right? I could do that.
But isnt the type="application/rss+json", instead of type="application/rss+xml"?

@himdel
Copy link

himdel commented Oct 30, 2024

Ah, yeah, it should be everywhere if we want that part to work :) (To be fair the last time majority of browsers supported this was like 2012, but I believe Opera still does, and there's extensions for the other browsers, such as https://chromewebstore.google.com/detail/rss-subscription-extensio/nlbjncdgjeocebhnmkbbbdekmmmcbfjd )

But isnt the type="application/rss+json", instead of type="application/rss+xml"?

Yeah, that's a valid point. I only ever saw rss+xml and atom+xml for rss/atom in the wild, but according to https://www.jsonfeed.org/, the correct mime-type is application/feed+json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants